[CCPPETMR/SIRF] zenodo: more author metadata, and ccp-petmr community (#391)
Casper da Costa-Luis
- add Zenodo metadata for automated release (https://doi.org/10.5281/zenodo.2707911)
- list of authors, ORCIDs, affiliations
- communities: CCP-PETMR
- licence: Apache-2.0
- related DOI: 10.1109/NSSMIC.2017.8532815
You can view, comment on, or merge this pull request online at:
https://github.com/CCPPETMR/SIRF/pull/391
Commit Summary
- zenodo: more author metadata, and ccp-petmr community
File Changes
- M .zenodo.json (18)
Patch Links:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
Casper da Costa-Luis
@KrisThielemans regarding foobar2016 previously appearing in Zenodo:
- it's no longer an issue if we're specifying authors in a metadata file
- apparently it's likely because a contributor used to have that username
codecov[bot]
Codecov Report
Merging #391 into master will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #391 +/- ## ======================================= Coverage 50.05% 50.05% ======================================= Files 2 2 Lines 1720 1720 ======================================= Hits 861 861 Misses 859 859
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update ea4a56f...0314fff. Read the comment docs.
codecov[bot]
Codecov Report
Merging #391 into master will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #391 +/- ## ======================================= Coverage 50.05% 50.05% ======================================= Files 2 2 Lines 1720 1720 ======================================= Hits 861 861 Misses 859 859
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update ea4a56f...0314fff. Read the comment docs.
—
Ashley Gillman
@ashgillman pushed 1 commit.
- cecba0e Add Gillman ORCID
—
You are receiving this because you are subscribed to this thread.
Ashley Gillman
Unrelated, but how did Johannes get an 'X' in his ORCID? I checked and it links correctly.
Casper da Costa-Luis
lol I noticed that
Casper da Costa-Luis
response from Zenodo support:
You can see the code that does the extraction here: https://github.com/inveniosoftware/invenio-github/blob/master/invenio_github/utils.py#L80-L108
I've tried to debug it, and I've traced the foobar2016 to this GitHub API response:
https://api.github.com/repos/CCPPETMR/SIRF/stats/contributors (https://developer.github.com/v3/repos/#list-contributors)
forbar2016 is listed there as having 3 contributions to the projectHow the user ended up there I didn't have time to look into yet.
Kris Thielemans
@KrisThielemans pushed 1 commit.
- bef2256 Update .zenodo.json
—
You are receiving this because you are subscribed to this thread.
Kris Thielemans
Currently, our license still has to be GPL 3 due to use of FFTW. can we say something like "GPL 3, but most parts also licensed as Apache 2.0"?
Kris Thielemans
@casperdcl I actually cannot see foobar2016 on our list of contributors. (Indeed, that user has no contributions to any repo anywhere). mystery.
Casper da Costa-Luis
can we say something like "GPL 3, but most parts also licensed as Apache 2.0"?
no but we can leave it as the default (Other - Open)
I actually cannot see
foobar2016on our list of contributors
good point, neither can I when I access the API. Sent a follow-up to Zenodo. They must have some weird caching issues.
Casper da Costa-Luis
@casperdcl pushed 1 commit.
- 1bcc2b4 remove licence for now
—
You are receiving this because you are subscribed to this thread.
Ashley Gillman
@ashgillman pushed 1 commit.
- d02f347 Also expand CSIRO
—
You are receiving this because you are subscribed to this thread.
Ashley Gillman
NB: You might have to accept #392 before this PR
Richard Brown
Richard Brown
Casper da Costa-Luis
@paskino you may want to check this file to find out author details
Casper da Costa-Luis
Follow-up from Zenodo:
I apologise, I sent the wrong [...] URL. The URL is https://api.github.com/repos/CCPPETMR/SIRF/contributors (without stats) [...] which includes
foobar2016.[...] you can see the commits here:
https://api.github.com/repos/CCPPETMR/SIRF/commits?author=foobar2016
Specifically [...]:
ddc363c
18b7e18
819d8a1
[...] authored by:
Evgueni Ovtchinnikov <m...@example.com>Why GitHub is associating the GitHub user
foobar2016with Evgueni Ovtchinnikov <m...@example.com>, I don't know. Perhaps because of the email address "m...@example.com" being used?
Ashley Gillman
Some quick edits on a cluster or another computer perhaps?
I've had similar experiences when making edits on the cluster and no email was set, GitHub doesn't associate the commits with my account.
You can modify these with
git config --global user.email "m...@example.com" and also user.name.
Kris Thielemans
my first thought was that github is a bit silly but I then realised that the commiter email is probably the only way they can do this. After all, you can have lots of local commits made by lots of different people, which then one github user pushes. Those commits should not be assigned to the github user of course. Therefore, github has to look at git content, which stores user.email and user.name for each commit. Makes sense.
We cannot fix this as it'd mean invalidating all commits since then (replacing them with new ones), so we'll live with it.
Moral of the store: be careful how you do your git config!
@casperdcl please thank your zenodo contact. Very helpful!
Casper da Costa-Luis
@casperdcl pushed 1 commit.
- aa42823 update zenodo format
—
You are receiving this because you are subscribed to this thread.
Casper da Costa-Luis
Merged #391 into master.