[CCPPETMR/SIRF] SIRF should use std::shared_ptr (#59)

0 views
Skip to first unread message

Kris Thielemans

unread,
Sep 21, 2017, 12:26:21 PM9/21/17
to CCPPETMR/SIRF, Subscribed

we're using boost::shared_ptr but as we force C++-11, there is no good reason to do that anymore.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Kris Thielemans

unread,
Sep 27, 2017, 5:10:44 AM9/27/17
to CCPPETMR/SIRF, Subscribed

@evgueni-ovtchinnikov could you create a PR for this based on your sirf_sptr branch? Easier to review it then. I guess this supersedes Casper's #61, so close that one (without merging) by referring to your new PR.

evgueni-ovtchinnikov

unread,
Sep 27, 2017, 6:40:21 AM9/27/17
to CCPPETMR/SIRF, Subscribed
Done.

From: Kris Thielemans [mailto:notifi...@github.com]
Sent: 27 September 2017 10:11
To: CCPPETMR/SIRF
Cc: Ovtchinnikov, Evgueni (STFC,RAL,SC); Mention
Subject: Re: [CCPPETMR/SIRF] SIRF should use std::shared_ptr (#59)


@evgueni-ovtchinnikov<https://github.com/evgueni-ovtchinnikov> could you create a PR for this based on your sirf_sptr branch? Easier to review it then. I guess this supersedes Casper's #61<https://github.com/CCPPETMR/SIRF/pull/61>, so close that one (without merging) by referring to your new PR.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/CCPPETMR/SIRF/issues/59#issuecomment-332459656>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AOWfVNmyp0Py8cRYgPnXMmQbitJ3ikYUks5smhESgaJpZM4PflSV>.

evgueni-ovtchinnikov

unread,
Sep 29, 2017, 6:54:32 AM9/29/17
to CCPPETMR/SIRF, Subscribed

Closed #59 via ac86a81.

Reply all
Reply to author
Forward
0 new messages