[CCPPETMR/SIRF-Exercises] old MR notebooks have multiple problems (#29)

Kris Thielemans

unread,

May 12, 2019, 4:33:27 PM5/12/19

to CCPPETMR/SIRF-Exercises, Subscribed

The older notebooks (not those in the interactive folder) were stripped too much and we get an error when opening them (see the process in #20).

They also need changing of petmr_data_path(...) with examples_data_path('MR').

However, I suspect that the notebooks in https://github.com/CCPPETMR/SIRF-Exercises/tree/master/notebooks/MR shouldn't really be there anymore and are superseded by those in interactive. @ckolbPTB @johannesmayer @DANAJK could you confirm that these are safe too delete?

I'm not sure what to do with those in tools. acqh5info might contain things that are now elsewhere. im5info uses h5py and seems interesting (but could need with some more info). @DANAJK ?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Edoardo Pasca

unread,

May 14, 2019, 11:40:52 AM5/14/19

to CCPPETMR/SIRF-Exercises, Subscribed

I was in the process of testing the notebooks.
I fixed the notebooks in MR #30

Except from this the others seem to work.

Kris Thielemans

unread,

May 15, 2019, 6:06:37 AM5/15/19

to CCPPETMR/SIRF-Exercises, Subscribed

what's the problem with the remaining one?

Kris Thielemans

unread,

May 23, 2019, 3:23:58 AM5/23/19

to CCPPETMR/SIRF-Exercises, Subscribed

Closed #29 via 4e03928.

Kris Thielemans

unread,

May 23, 2019, 3:25:20 AM5/23/19

to CCPPETMR/SIRF-Exercises, Subscribed

I've created a separate issue for the remaining problem. #31

Reply all

Reply to author

Forward