[SyneRBI/SIRF] Fixed dicom output via ImageProcessor chain. (PR #1143)
Evgueni Ovtchinnikov
Changes in this pull request
Main change: added missing call of GTConnector::send_gadgetron_parameters in ImageProcessor::process.
Testing performed
Seems to work ok with Gadgetron 4.1.2, gadgetron 3.17 fails sometimes.
Related issues
Checklist before requesting a review
- I have performed a self-review of my code
- I have added docstrings/doxygen in line with the guidance in the developer guide
- I have implemented unit tests that cover any new or modified functionality
- The code builds and runs on my machine
- CHANGES.md has been updated with any functionality change
Contribution Notes
Please read and adhere to the contribution guidelines.
Please tick the following:
- The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in SIRF (the Work) under the terms and conditions of the Apache-2.0 License.
You can view, comment on, or merge this pull request online at:
https://github.com/SyneRBI/SIRF/pull/1143
Commit Summary
- 5acd2b6 fixed dicom output via ImageProcessor chain; gadgetron 3.17 fails sometimes
File Changes
(3 files)
- M examples/Python/MR/grappa_basic.py (24)
- M src/xGadgetron/cGadgetron/gadgetron_x.cpp (12)
- M src/xGadgetron/cGadgetron/include/sirf/Gadgetron/gadgetron_x.h (2)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Evgueni Ovtchinnikov
@evgueni-ovtchinnikov pushed 1 commit.
- 87ba87d [ci skip] restored several-chains demo following PR 1143 bugfix
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Evgueni Ovtchinnikov
@evgueni-ovtchinnikov pushed 3 commits.
- cc0758f [ci skip] removed obsolete two Gadgetron chains demo
- 9ad15b5 attended to Codacy issues
- f4e06d5 [ci skip] removed commented-out DICOM quick-fix lines in grappa_basic.py
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Evgueni Ovtchinnikov
@evgueni-ovtchinnikov pushed 1 commit.
- 36ca299 attended to Codacy issues
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Evgueni Ovtchinnikov
@evgueni-ovtchinnikov pushed 1 commit.
- 21878dc small amendments applied
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Evgueni Ovtchinnikov
@evgueni-ovtchinnikov pushed 3 commits.
- 2f3e854 multi-chain demo to complain about old Gadgetron
- a6d51bb [ci skip] commented out quick fix throw in get_output()
- 0ea3854 [ci skip] updated CHANGES.md
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Evgueni Ovtchinnikov
@evgueni-ovtchinnikov pushed 1 commit.
- 3d80fa7 Merge branch 'master' into try-fix-ip-chain
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Evgueni Ovtchinnikov
Merged #1143 into master.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.