[CCPPETMR/SIRF-SuperBuild] Use Matlab_ROOT_DIR as opposed to MATLAB_ROOT (#45)

[Kris Thielemans]

WARNING: This breaks backwards compatibility.

Matlab_ROOT_DIR is the variable used by CMake's FindMatlab.cmake so is what we should use as well.

Currently we use this to set both variables for SIRF (as SIRF 0.9.0 used MATLAB_ROOT).

---

You can view, comment on, or merge this pull request online at:

  https://github.com/CCPPETMR/SIRF-SuperBuild/pull/45

Commit Summary

• Use Matlab_ROOT_DIR as opposed to MATLAB_ROOT

File Changes

• M SuperBuild.cmake (2)
• M SuperBuild/External_SIRF.cmake (5)

Patch Links:

• https://github.com/CCPPETMR/SIRF-SuperBuild/pull/45.patch
• https://github.com/CCPPETMR/SIRF-SuperBuild/pull/45.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[Kris Thielemans]

If you want to try SIRF FindMatlab branch, use

cmake -DSIRF_TAG=FindMatlab 

Potentially add -DMatlab_ROOT_DIR=.... if you need it (and for testing)

[Kris Thielemans]

merging this will need updates to the wiki.

[Kris Thielemans]

Merged #45.