[CCPPETMR/Hackathon-SIRF] Convert SPDHG to CIL optimization (#1)
Matthias J. Ehrhardt
use A(x) <=> A.direct(x)
use A.adjoint(x, out=y) <=> y = A.adjoint(x)
use f.proximal(tau)(x) <=> f.prox(x, tau)
f.convex_conj <=> f_cvx
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
Matthias J. Ehrhardt
This has been implemented by 53453fe. The code is not really documented nor well written. Moreover, there are several examples missing. Finally, the more code is needed to add regularization to it, for example from CCPi.
Edoardo Pasca
I guess we could add proximal rather than prox and it's a good idea to add out=y.
Edoardo Pasca
I added the CIL optimisation and regularisation to SIRF SuperBuild CCPPETMR/Hackathon-SIRF-SuperBuild#1
Matthias J. Ehrhardt
I guess we could add proximal rather than prox and it's a good idea to add out=y.
@paskino, yes, that would be a good idea! This way CIL is also more compatible to ODL which might turn out to be useful at some point.
Edoardo Pasca
WIP in vais-ral/CCPi-Framework#129
Kris Thielemans
@mehrhardt could you create an issue in SIRF (not hackathon) with where the out syntax is needed? It could be initially done as a work-around (for compatibility), but for PET it should be easy.
Please also say what out is supposed to do. should it check if sizes etc are as expected? What to do if they're not? Should it overwrite or add to existing data?
Possibly point us to the ODL doc, or we can get some ODL people involved.
Matthias J. Ehrhardt
Matthias J. Ehrhardt
This issue can be closed as 5efd25a completes its implementation and simple example showing its usage. However, all code for SPDHG is far from tidied up and should be included at appropriate places in SIRF and/or CIL. It might be best to create a new issue for this.