[CCPPETMR/SIRF-SuperBuild] Handle different options for different versions of dependencies (#43)

[Kris Thielemans]

With the version tracking, we can use the SuperBuild to use different versions of SIRF, STIR etc. However, some CMake options will be version specific. Example, CCPPETMR/SIRF#41 will need Matlab_ROOT_DIR as opposed to MATLAB_ROOT. The SuperBuild needs to know about this, but how would it?

In principle, we could keep a list of commits where the option changed, and then check if it's an ancester of the desired TAG using something like

git rev-list ${COMMIT_HASH_WITH_NEW_OPTION}| grep $(git rev-parse ${${SIRF_GIT_TAG})

(after CMake-ifying this) but keeping the list is error-prone and tedious.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[Kris Thielemans]

the rev-list is essentially impossible in the SuperBuild anyway as we have don't explicitly clone here, but rely on ExternProject_Add

[Kris Thielemans]

Closed #43.

[Kris Thielemans]

This seems not necessary since we've introduced version_config.cmake. If a user switches to an old STIR_TAG (or other dependency) and the options need to change, it's not really for us to handle that properly I think. So closing.