[CCPPETMR/SIRF] although it was correct, osx gave lots of warnings for -Wlogical-op-parentheses (#386)

0 views
Skip to first unread message

Richard Brown

unread,
May 17, 2019, 6:37:55 AM5/17/19
to CCPPETMR/SIRF, Subscribed

replace if (a || b && c) with if (a || (b && c)) even though the two are the same.


You can view, comment on, or merge this pull request online at:

  https://github.com/CCPPETMR/SIRF/pull/386

Commit Summary

  • although it was correct, osx gave lots of warnings for -Wlogical-op-parentheses

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Richard Brown

unread,
May 17, 2019, 7:30:01 AM5/17/19
to CCPPETMR/SIRF, Push

@rijobro pushed 1 commit.

  • 6ab0a5d fix missing return in assignment constructor


You are receiving this because you are subscribed to this thread.

View it on GitHub or mute the thread.

codecov[bot]

unread,
May 17, 2019, 7:30:03 AM5/17/19
to CCPPETMR/SIRF, Subscribed

Codecov Report

Merging #386 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@

##           master     #386   +/-   ##

=======================================

  Coverage   50.05%   50.05%           

=======================================

  Files           2        2           

  Lines        1720     1720           

=======================================

  Hits          861      861           

  Misses        859      859

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25565a0...6ab0a5d. Read the comment docs.

codecov[bot]

unread,
May 17, 2019, 7:30:03 AM5/17/19
to CCPPETMR/SIRF, Subscribed

Codecov Report

Merging #386 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@

##           master     #386   +/-   ##

=======================================

  Coverage   50.05%   50.05%           

=======================================

  Files           2        2           

  Lines        1720     1720           

=======================================

  Hits          861      861           

  Misses        859      859

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25565a0...6ab0a5d. Read the comment docs.

Richard Brown

unread,
May 17, 2019, 9:12:37 AM5/17/19
to CCPPETMR/SIRF, Subscribed

Merged #386 into master.

Reply all
Reply to author
Forward
0 new messages