[SyneRBI/SIRF-SuperBuild] disable hdf5 by default (#407)

0 views
Skip to first unread message

Richard Brown

unread,
Jun 4, 2020, 11:03:07 AM6/4/20
to SyneRBI/SIRF-SuperBuild, Subscribed

In spite of #404, STIR HDF5 support still being built on PRs, causing them to fail: https://travis-ci.org/github/SyneRBI/SIRF-SuperBuild/jobs/694165572#L22214-L22217.

I'm guessing this is because there are two bools controlling it in STIR. Set them to both use the same boolean SuperBuild value.


You can view, comment on, or merge this pull request online at:

  https://github.com/SyneRBI/SIRF-SuperBuild/pull/407

Commit Summary

  • disable hdf5 by default

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Kris Thielemans

unread,
Jun 4, 2020, 11:45:50 AM6/4/20
to SyneRBI/SIRF-SuperBuild, Subscribed

There has never been a DISABLE_HDF5_SUPPORT as far as I can see. It certainly is DISABLE_HDF5 in STIR release_4 branch (it isn't yet anywhere else I believe).

Kris Thielemans

unread,
Jun 4, 2020, 11:46:16 AM6/4/20
to SyneRBI/SIRF-SuperBuild, Subscribed

please remove the *SUPPORT variable therefore

Richard Brown

unread,
Jun 4, 2020, 11:49:16 AM6/4/20
to SyneRBI/SIRF-SuperBuild, Push

@rijobro pushed 1 commit.

  • 1215052 remove variable STIR_DISABLE_HDF5_SUPPORT


You are receiving this because you are subscribed to this thread.

View it on GitHub or unsubscribe.

Richard Brown

unread,
Jun 5, 2020, 4:53:13 AM6/5/20
to SyneRBI/SIRF-SuperBuild, Subscribed

Merged #407 into master.

Reply all
Reply to author
Forward
0 new messages