[SyneRBI/SIRF-Exercises] Can no longer install numba with python 2 (#45)
Kris Thielemans
The synergistic demos use brainweb, which starts by using pip install numba. That now fails
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Casper da Costa-Luis
I think numba is a leftover from some performance hacks @rijobro was trying - looks like it can be removed.
Richard Brown
yeah, it looks like it wasn't actually being used in the notebook. It is, however, used in a few others (but not pip installed):
- https://github.com/SyneRBI/SIRF-Exercises/blob/master/notebooks/Synergistic/de_Pierro_MAPEM.ipynb
- https://github.com/SyneRBI/SIRF-Exercises/blob/master/notebooks/Synergistic/Solutions/Dual_PET_Answer-noMotion.ipynb
- https://github.com/SyneRBI/SIRF-Exercises/blob/master/notebooks/Synergistic/Solutions/Dual_PET_Answer-wMotion.ipynb
Kris Thielemans
Serves us right from not upgrading to Python 3. @paskino, this will have to be a priority after 2.2 (unless it's a matter of dropping in ubuntu 20.04, but that seems unlikely!)
I suggest to move the import numba to a new cell, but commented out, saying that they can uncomment it and subsequent @jit lines if they have python3 (and numba).
Casper da Costa-Luis
How much of a speedup does it really give in those notebooks? May just be better to leave it out...
Richard Brown
Comment from a notebook says
Using jit gets computation time from 90 secs to 2!
So I'm inclined to comment it out rather than delete.