[SynerBI/CCPPETMR_VM] changes repos links to synerbi (#151)
Edoardo Pasca
You can view, comment on, or merge this pull request online at:
https://github.com/SynerBI/CCPPETMR_VM/pull/151
Commit Summary
- changes repos links to synerbi
File Changes
- M scripts/UPDATE.sh (9)
Patch Links:
- https://github.com/SynerBI/CCPPETMR_VM/pull/151.patch
- https://github.com/SynerBI/CCPPETMR_VM/pull/151.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Kris Thielemans
@KrisThielemans requested changes on this pull request.
> git fetch + git pull
can't do an explicit pull. The rest of the script will take care of it. fetch updates the content of the remote branches. pull would do fetch and merge
Kris Thielemans
@KrisThielemans commented on this pull request.
⬇️ Suggested change- git pull
Kris Thielemans
we probably need to manage that an old VM will have files in ~/devel/CCPPETMR_VM which will now have been changed.
This most likely also affects this wiki
Edoardo Pasca
@paskino commented on this pull request.
Sure? I added it just because fetch wouldn't suffice. I'll try again.
Edoardo Pasca
It seems to me that we only request:
- fetch
- checkout to a different tag
I don't see how the rest of the script does a pull of the SyneRBI_VM if we don't change branch. Am I wrong?
Kris Thielemans
Edoardo Pasca
@paskino commented on this pull request.
I removed the pull
—
You are receiving this because you are subscribed to this thread.
Edoardo Pasca
What about creating a symbolic link? SyneRBI_VM -> CCPPETMR_VM
Kris Thielemans
@KrisThielemans commented on this pull request.
a few more rBI->RBI
needs a line in CHANGES.md.
are you going to do the doc changes in a separate PR? (could do a separate)
> cd SIRF-SuperBuild
else
cd SIRF-SuperBuild
+ # update the remote repository after rename to SynerBI
+ git remote set-url origin https://github.com/SynerBI/SIRF-SuperBuild.git
⬇️ Suggested change
- git remote set-url origin https://github.com/SynerBI/SIRF-SuperBuild.git + git remote set-url origin https://github.com/SyneRBI/SIRF-SuperBuild.git
and all others
Kris Thielemans
Needs repo changes in bootstrap_ubuntu.sh and possibly other files
Kris Thielemans
What about creating a symbolic link? SyneRBI_VM -> CCPPETMR_VM
good idea, if CCPPETMR_VM exists and SyneRBI_VM doesn't, create the link
Kris Thielemans
update.sh needs to use ~/devel/SyneRBI_VM. Probably other things as well.
Edoardo Pasca
What about creating a symbolic link? SyneRBI_VM -> CCPPETMR_VM
good idea, if CCPPETMR_VM exists and SyneRBI_VM doesn't, create the link
I'm thinking that this is going to complicate the things in a consistent way for no real reason. The important bit is to update the github links (though not fundamental either).
Wouldn't it be better to create a new VM? We may then release it with SIRF as 2.1.x.
Kris Thielemans
I'm thinking that this is going to complicate the things in a consistent way for no real reason.
You mean creating the CCPPETMR_VM link? Or change update.sh? Things have to work, both for a new one and for updating an existing (but not too old) one. Not everyone is using their VMs for a short time (otherwise, why do we have the update mechanism at all?).
Wouldn't it be better to create a new VM? We may then release it with SIRF as 2.1.x.
Agreed that it would be best to create a new VM, but it seems hard to do it without a new release. how are we going to call it otherwise?
Edoardo Pasca
@paskino pushed 3 commits.
- 3bb1ab2 update to SyneRBI
- bc699c0 create symbolic link SyneRBI_VM->CCPPETMR_VM
- 654958e Merge branch 'synerbi_transition' of https://github.com/CCPPETMR/CCPPETMR_VM into synerbi_transition
—
You are receiving this because you are subscribed to this thread.
Kris Thielemans
Kris Thielemans
@KrisThielemans pushed 2 commits.
- 35d1910 moved linking of CCPETMR_VM to SyneRBI to UPDATE.sh
- b2f304a More CCPPETMR->SyneRBI textual changes
Edoardo Pasca
@paskino pushed 2 commits.
- 3c2ec4a change SyneRBI_VM -> CCPPETMR_VM
- d4a8e96 Merge branch 'synerbi_transition' of https://github.com/CCPPETMR/CCPPETMR_VM into synerbi_transition
Kris Thielemans
@KrisThielemans requested changes on this pull request.
looks good to me, but probably a good time to update SIRF_VM_VERSION (note that it occurs in an if below).
—
You are receiving this because you are subscribed to this thread.
Edoardo Pasca
created a VM from scratch with this branch and it works. I'll try to upload it somewhere for test.
Edoardo Pasca
Kris Thielemans
This looks ok to me now. However, I did spot a problem with the automatic set remote. On my VM, I had changed the remote manually to something else (actually g...@github.com:... such that I don't need to type passwords all the time). Doing on update_VM.sh got rid of all these.
As the ccppetmr redirects are all working fine, I suggest that we remove these. People with old VMs will have no problems. People with new VMs will get the synerbi repo.
Objections? @casperdcl @paskino
Kris Thielemans
@KrisThielemans pushed 2 commits.
—
You are receiving this because you are subscribed to this thread.
Kris Thielemans
I've introduced an option for the remote. Also changed the "version" stuff a bit.
—
You are receiving this because you are subscribed to this thread.
Kris Thielemans
Merged #151 into master.