Re: [SyneRBI/SIRF] added pass through of threshold for recon (#544)

Kris Thielemans

unread,

Apr 25, 2020, 2:48:07 AM4/25/20

to SyneRBI/SIRF, Subscribed

@ALEXJAZZ008008 could you give this a quick look such that we can merge it in before 2.2? Should only take 5 mins to add in the doc. I don't see why this PR should be updating the data submodule though. As that's rather fragile, I'd vastly prefer if it doesn't.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Alexander Whitehead

unread,

Apr 26, 2020, 8:47:41 PM4/26/20

to SyneRBI/SIRF, Subscribed

Yes, I'll look at this first thing tomorrow.
I agree that there shouldn't be changes to data I believe this will be because I used "got add ."

Alexander Whitehead

unread,

Apr 27, 2020, 1:16:50 PM4/27/20

to SyneRBI/SIRF, Push

@ALEXJAZZ008008 pushed 1 commit.

59bb749 Merge branch 'master' of https://github.com/SyneRBI/SIRF into passthrough_threshold_for_recon

—
You are receiving this because you are subscribed to this thread.

View it on GitHub or unsubscribe.

Alexander Whitehead

unread,

Apr 27, 2020, 3:15:37 PM4/27/20

to SyneRBI/SIRF, Subscribed

Closed #544.

—
You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward