Breaking change in AddFacility

[Mauricio Scheffer]

While trying to upgrade the Quartz.NET facility ( https://github.com/castleprojectcontrib/QuartzNetIntegration ) to Windsor 3, I found a breaking change I'm not sure how to overcome.

Concretely, this test breaks:  https://github.com/castleprojectcontrib/QuartzNetIntegration/blob/5fca07bb7252b18b06a77e88cecc1181c39d1787/QuartzNetIntegration.Tests/FacilityTests.cs#L31 because FacilityConfig is null.

It looks as if the facility's FacilityConfig property isn't being populated from the ConfigurationStore.

I received a patch with a workaround that simply skips the FacilityConfig and passes an IConfiguration explicitly :  https://github.com/jochenjonc/QuartzNetIntegration/commit/78cb6f191bf00a02f3ebccd17c01998882705c1f 

But it's really a workaround... any ideas why I can't get the FacilityConfig to work?

Of course, this used to work in Windsor 2.5.

Thanks.

Mauricio

[Krzysztof Koźmic]

I think it's a regression.

Not sure exactly about the details what changed that caused it to stop
working and why none of our tests caught that. I'm pretty sure we have
tests that depend on the config, so I think it's unlikely it's not
populated when it's not there anymore.

Please add that to YouTrack.

@K

> --
> You received this message because you are subscribed to the Google
> Groups "Castle Project Users" group.
> To post to this group, send email to
> castle-pro...@googlegroups.com.
> To unsubscribe from this group, send email to
> castle-project-u...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/castle-project-users?hl=en.

[Mauricio Scheffer]

Thanks, I just wanted to make sure I wasn't overlooking some known breaking change or something like that.

I'll try to come up with a proper test for this.

Cheers,

Mauricio

2012/3/22 Krzysztof Koźmic <krzyszto...@gmail.com>

I think it's a regression.

Not sure exactly about the details what changed that caused it to stop working and why none of our tests caught that. I'm pretty sure we have tests that depend on the config, so I think it's unlikely it's not populated when it's not there anymore.

Please add that to YouTrack.

@K

On 22/03/2012 7:37 AM, Mauricio Scheffer wrote:

While trying to upgrade the Quartz.NET facility ( https://github.com/castleprojectcontrib/QuartzNetIntegration ) to Windsor 3, I found a breaking change I'm not sure how to overcome.

Concretely, this test breaks: https://github.com/castleprojectcontrib/QuartzNetIntegration/blob/5fca07bb7252b18b06a77e88cecc1181c39d1787/QuartzNetIntegration.Tests/FacilityTests.cs#L31 because FacilityConfig is null.

It looks as if the facility's FacilityConfig property isn't being populated from the ConfigurationStore.

I received a patch with a workaround that simply skips the FacilityConfig and passes an IConfiguration explicitly : https://github.com/jochenjonc/QuartzNetIntegration/commit/78cb6f191bf00a02f3ebccd17c01998882705c1f
But it's really a workaround... any ideas why I can't get the FacilityConfig to work?
Of course, this used to work in Windsor 2.5.

Thanks.

Mauricio

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.

To post to this group, send email to castle-project-users@googlegroups.com.
To unsubscribe from this group, send email to castle-project-users+unsub...@googlegroups.com.

For more options, visit this group at http://groups.google.com/group/castle-project-users?hl=en.

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.

To post to this group, send email to castle-project-users@googlegroups.com.
To unsubscribe from this group, send email to castle-project-users+unsub...@googlegroups.com.

[Mauricio Scheffer]

Registered with failing test:  http://issues.castleproject.org/issue/IOC-334 

Cheers,

Mauricio

[Krzysztof Koźmic]

cheers,

I'll get it fixed for v3.0.1 whenever that is :)

@K

Cheers,

Mauricio

2012/3/22 Krzysztof Koźmic <krzyszto...@gmail.com>

To post to this group, send email to castle-pro...@googlegroups.com.
To unsubscribe from this group, send email to castle-project-u...@googlegroups.com.

For more options, visit this group at http://groups.google.com/group/castle-project-users?hl=en.

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.

To post to this group, send email to castle-pro...@googlegroups.com.
To unsubscribe from this group, send email to castle-project-u...@googlegroups.com.

For more options, visit this group at http://groups.google.com/group/castle-project-users?hl=en.

--
You received this message because you are subscribed to the Google Groups "Castle Project Users" group.

To post to this group, send email to castle-pro...@googlegroups.com.
To unsubscribe from this group, send email to castle-project-u...@googlegroups.com.