Contrib Code Generator
Lee Henson
It's hacked together a bit, and I'm pretty sure I don't quite grasp
exactly all the nuances of the routing engine.
[StaticRoute("Products", "products")]
public void ProductsList()
{
}
Accessible via: Routes.Products()
Set up via: RoutingModuleEx.Engine.Add(RouteDefinitions.Products)
[PatternRoute("Product", "products/<productKey:guid>")]
public void Product(Guid productKey)
{
}
Accessible via: Routes.Product(new Guid())
Set up via: RoutingModuleEx.Engine.Add(RouteDefinitions.Product)
[PatternRoute("Complex", "<thing:anyof(this|that)/<foo:guid>/<bar:int>/
<zoo>/[beep]", "thing=this")]
public void Parp(Guid foo, int bar, string zoo, string beep)
{
}
Accessible via: Routes.Complex(fooGuid, intBar, zoo, beep)
Set up via: RoutingModuleEx.Engine.Add(RouteDefinitions.Complex)
Adam Tybor
int as validation try's to call ValidInt instead of ValidInteger. I
am also missing the MyRoutes now and Site.Routes.
James Curran
Can I get contrib commit access? One thing I noticed is that using
int as validation try's to call ValidInt instead of ValidInteger. I
am also missing the MyRoutes now and Site.Routes.
--
Truth,
James
Lee Henson
> int as validation try's to call ValidInt instead of ValidInteger.
> I am also missing the MyRoutes now and Site.Routes.
associate routes with a specific controller. I think I've probably
been overzealous there though. It's easy enough to add back in though.
Site.Routes doesn't exist I don't think, it's just
Routes.<RouteName>()
I'm off to the Alps now for a week, so I look forward to lots of
improvements when I get back! ;p
On 18 Jan, 18:11, "Adam Tybor" <adam.ty...@gmail.com> wrote:
> Can I get contrib commit access? One thing I noticed is that using
> int as validation try's to call ValidInt instead of ValidInteger. I
> am also missing the MyRoutes now and Site.Routes.
>
Ken Egozi
;)
have fun.
Ken Egozi
:-0
Steve Wagner
[PatternRoute("Foo", "feed/foo/<id>")
public void Foo() {}
[PatternRoute("Bar", "feed/bar/<id>")
public void Bar() {}
If i call now Routes.Foo() or Route.Bar() if always get the same url. This is because the generates generates this:
public virtual string Foo(string id) {
System.Collections.IDictionary routeParameters Castle.MonoRail.Framework.Helpers.DictHelper.Create();
routeParameters.Add("id", id);
return this.engineContext.Services.UrlBuilder.BuildUrl(this.engineContext.UrlInfo, new System.Collections.Hashtable(), routeParameters);
}
public virtual string Bar(string id) {
System.Collections.IDictionary routeParameters Castle.MonoRail.Framework.Helpers.DictHelper.Create();
routeParameters.Add("id", id);
return this.engineContext.Services.UrlBuilder.BuildUrl(this.engineContext.UrlInfo, new System.Collections.Hashtable(), routeParameters);
}
And on my perspective this calls are the same. I think this calls must be look like this:
public virtual string Foo(string id) {
System.Collections.IDictionary routeParameters Castle.MonoRail.Framework.Helpers.DictHelper.Create();
routeParameters.Add("id", id);
return RouteDefinitions.Foo.CreateUrl( routeParameters );
}
public virtual string Bar(string id) {
System.Collections.IDictionary routeParameters Castle.MonoRail.Framework.Helpers.DictHelper.Create();
routeParameters.Add("id", id);
return RouteDefinitions.Foo.CreateUrl( routeParameters );
}
I someone can confirm this i will look forward to write a patch for it.
Steve
Lee Henson schrieb:
Lee Henson
Yeah I see that behaviour too. Did you get around to writing a patch?
I can commit it for you.
Steve Wagner
at the moment.
Steve
Lee Henson schrieb:
Lee Henson
Steve Wagner
it first next week.
I also have a few other things in my head which the generator can be
extend and i list them here. Possibly you find the time and interest to
code them before i get time to do it.
* RouteDefinitions.AddAll(RoutingEngine engine)
* Add a sample project which demonstrates how to use the generator
* Generate a the needed SiteMapControllerBase into SiteMap.generated.cs
(The Controller which provides access to Site and Routes)
* Routes.Foo should return a IRouteActionReference and
IArgumentlessRouteActionReference insted of a string
* Extend IArgumentlessControllerActionReference with "RouteUrl"
By
Steve
Lee Henson schrieb:
Lee Henson
Hi Lee thanks for doing it! I am too busy at the moment and i could test
it first next week.
I also have a few other things in my head which the generator can be
extend and i list them here. Possibly you find the time and interest to
code them before i get time to do it.
Alas, that looks unlikely. I'm only in this code because I need to add support for rest routes.
* RouteDefinitions.AddAll(RoutingEngine engine)
The problem with this is the ordering of the rules. If you wanted them automatically registered you would need to put some sort of index parameter on the route attributes: [PatternRoute(25, "sdfasdf", ....)]. We used to have this, but as soon as you start to get past anything other than a trivial amount of rules, it quickly gets obscure. Better to have all the rules registered in one place where you can see them at one glance.
* Add a sample project which demonstrates how to use the generator
* Generate a the needed SiteMapControllerBase into SiteMap.generated.cs
(The Controller which provides access to Site and Routes)
That forces you to use a specific base class for your controllers. While that may be valid in some scenarios, it is not for all. By adding the appropriate methods/properties yourself, you remain in control of how class hierarchy.
* Routes.Foo should return a IRouteActionReference and
IArgumentlessRouteActionReference insted of a string
Reasonable.
* Extend IArgumentlessControllerActionReference with "RouteUrl"
Reasonable.
Steve Wagner
Lee Henson schrieb: