Windsor Integrated Dynamic Actions

0 views
Skip to first unread message

Mike Nichols

unread,
Apr 18, 2008, 4:55:11 PM4/18/08
to Castle Project Development List
Hi All,
A while back I posted a MonoRail patch (http://
support.castleproject.org/browse/MR-396) that implements
WindsorIntegration for DynamicActionProviders.
I updated the patch after the big controller refactoring a while back
and before I updated the patch again I wanted to see if anyone else
found value in this functionality and might consider it for inclusion
in MonoRail .
I have found it very useful on apps I've deployed as I have more
flexibility in reusing logic for my actions. I extended the existing
test cases to test the new feature.

Any feedback on whether I should continue to keep this up-to-date with
monorail or just let it die?

Thanks!

Mike

Ken Egozi

unread,
Apr 19, 2008, 3:05:42 AM4/19/08
to castle-pro...@googlegroups.com
I'm in favor of applying it, and would have done so, however it is not complying with our coding standards.

A. use tabs and not spaces (and you can see that the patch actually begins with a R# change that breaks that)
B. using declarations should be within the namespace

please do fix it, and make sure tests are passing. We'll find the time then to apply it.

10x for keeping it alive for the community.
--
Ken Egozi.
http://www.kenegozi.com/blog
http://www.musicglue.com
http://www.castleproject.org
http://www.mamaherb.com
http://www.gotfriends.co.il

Mike Nichols

unread,
Apr 19, 2008, 11:36:30 PM4/19/08
to Castle Project Development List
Great thanks for the response Ken...
I'll fix my misteaks and resubmit the patch then. I'm not sure why the
patch isn't tab indented since I use R# and don't use spaces for
indenting...I'll figure it out.

On Apr 19, 12:05 am, "Ken Egozi" <egoz...@gmail.com> wrote:
> I'm in favor of applying it, and would have done so, however it is not
> complying with our coding standards.
>
> A. use tabs and not spaces (and you can see that the patch actually begins
> with a R# change that breaks that)
> B. using declarations should be within the namespace
>
> please do fix it, and make sure tests are passing. We'll find the time then
> to apply it.
>
> 10x for keeping it alive for the community.
>
> On Fri, Apr 18, 2008 at 11:55 PM, Mike Nichols <nichols.mik...@gmail.com>

c.sokun

unread,
Apr 20, 2008, 4:25:09 PM4/20/08
to Castle Project Development List

Mike Nichols

unread,
Apr 20, 2008, 5:09:31 PM4/20/08
to Castle Project Development List
Yeah I had just not selected the option in VS Setup. I figure it out.
Thanks


On Apr 20, 1:25 pm, "c.sokun" <chornso...@gmail.com> wrote:
> Mike, you just hit the same problem as I did check it herehttp://chorn-sokun.blogspot.com/2008/03/tabify-why-i-never-care.html
Reply all
Reply to author
Forward
0 new messages