Any objections to moving to NHibernate Trunk?

[Ayende Rahien]

Hi guys,
I am going over the new stuff in NHibernate, and we have today moved our own project to the trunk (were using an older version of the trunk).
I believe it to be stable enough to move Castle trunk to it.
Any objections?

[Shawn Carr]

No objections from me but I was wondering if you / someone can provide a list of what would be new as the last time I looked at the NHibernate trunk has been some time now.

[James Curran]

My first thought was "Sure,  why would we do it any other way" --- Then I realized that NHibernate isn't hosted here.  Switching to the NHibernate trunk would be tying the functioning of our code to something outside our control.   That's probably not a good idea.   (but then, I don't use NHibernate so factor that into the value to offer my opinion)

[Dario Quintana]

Hi, some days ago I made this list with some visibles features of
NHibernate 2.
http://darioquintana.com.ar/blogging/?p=13

How I could not wait, I have done some extensions for ActiveRecordBase/
ActiveRecordBase<T>/ActiveRecordValidationBase/
ActiveRecordValidationBase<T> for support of DetachedQuery (the wich
is only available at trunk or at uNHAddIns http://code.google.com/p/unhaddins/)
at the sub-project *uNhAddIns.ActiveRecord*
This are some links:
http://darioquintana.com.ar/blogging/?p=15
http://code.google.com/p/unhaddins/wiki/ActiveRecordAndDetachedQuery

What do you think about this ? I wanna hear comments.

[Hamilton Verissimo]

Cool, what about a patch? :-)

--
Cheers,
hamilton verissimo
ham...@castlestronghold.com
http://www.castlestronghold.com/

[Dario Quintana]

A patch could be great ! But...

DetachedQuery it's at uNHAddIns.dll
ActiveRecord enhanced classes are at uNhAddIns.ActiveRecord.dll,  (which depend of uNHAddIns.dll).

Possibilities:

Option 1) Bring these dll as external lib at Castle, and make it part of it.
Option 2) Bring only uNHAddIns.dll, the which have the implementation of DetachedQuery and copy only the method into the respectives classes of the core of ActiveRecord (at ActiveRecord.dll). And now the dll ActiveRecord will depend of uNHAddIns.dll.

What do you have in mind ?

Best regards.

On Nov 13, 2007 12:58 AM, Hamilton Verissimo < ham...@castlestronghold.com> wrote:

Cool, what about a patch? :-)

On 11/12/07, Dario Quintana <cont...@darioquintana.com.ar> wrote:
>
> Hi, some days ago I made this list with some visibles features of
> NHibernate 2.
> http://darioquintana.com.ar/blogging/?p=13
>
> How I could not wait, I have done some extensions for ActiveRecordBase/
> ActiveRecordBase<T>/ActiveRecordValidationBase/
> ActiveRecordValidationBase<T> for support of DetachedQuery (the wich
> is only available at trunk or at uNHAddIns http://code.google.com/p/unhaddins/)
> at the sub-project *uNhAddIns.ActiveRecord*
> This are some links:
> http://darioquintana.com.ar/blogging/?p=15
> http://code.google.com/p/unhaddins/wiki/ActiveRecordAndDetachedQuery
>
> What do you think about this ? I wanna hear comments.

--
Dario Quintana
http://darioquintana.com.ar/blogging

[Ken Egozi]

does uNHAddins depends on NH2?

we use NH trunk with Castle.
the process is:
Get NH trunk, build it and put in Castle's Lib.
Build Castle - all tests are green.

moving to NH2 does not break any test - so I say +1 for trunking NH

[Ernst Naezer]

+1 for me as well!

[Aaron Jensen]

I'm good w/ it. But please wait until I get my sql2k5 setmaxresults
patch in.. should send it to you tomorrow oren.

[Markus Zywitza]

Ayende,
I guess that means that you now think it's fairly stable. I am then
fine with it.

However, I have one question to all: Can Castle's release schedule be
aligned to NH2 release schedule? Since NH is the most important single
dependency of Castle, we need an GA release of it for finishing 1.0.
It also means that future releases must either built against NH trunk,
or branched with NH release versions.

I propose to switch to NH trunk now and freeze/change to NH2 GA, as
soon as it is available.

-Markus

[Craig Neuwirt]

+1

Been using it for a while and seems very stable

[Dario Quintana]

Hey,

No, uNHAddIns use NH 1.2, the same lib that Castle. The only reason it's use this library is the implementation for DetachedQuery.

If we move to NH trunk, is not necessary to use uNHAddIns, instead we use the DetachedQuery available at NH trunk, and then I summit a patch with the support and tests of DetachedQuery at ActiveRecord*Base/<T>.

Regards

On Nov 13, 2007 4:22 AM, Ken Egozi <ego...@gmail.com> wrote:

does uNHAddins depends on NH2?

we use NH trunk with Castle.
the process is:
Get NH trunk, build it and put in Castle's Lib.
Build Castle - all tests are green.

moving to NH2 does not break any test - so I say +1 for trunking NH

[Dario Quintana]

Hi all,

Ayende, when will be available NH2 at Castle trunk ?

[Ayende Rahien]

This weekend

[c.sokun]

How about Rhino-Common? will it also move into Castle trunk?

[Ayende Rahien]

No, it is a separate thing.

[Markus Zywitza]

Hi Ayende

On 11/15/07, Ayende Rahien <aye...@ayende.com> wrote:
> > Ayende, when will be available NH2 at Castle trunk ?

> This weekend
Did you refrain from it because of errors/objections or was it simply no time?

-Markus

[Ayende Rahien]

Just got back from reserve duty, didn't have the time.
Sorry

[Ken Egozi]

you have got 30 seconds to commit.

MOVE !!

[Ayende Rahien]

Actually, that is MY line.

[Ayende Rahien]

thinking about it, the actual response would be in the order of, "chill out man, check out that babe"