[castle][JIRA] Created: (COMP-23) Validators should always use ErrorMessage instead of calling BuildErrorMessage directly

[goodwill (JIRA)]

Validators should always use ErrorMessage instead of calling BuildErrorMessage directly
---------------------------------------------------------------------------------------

Key: COMP-23
URL: http://support.castleproject.org//browse/COMP-23
Project: Components
Issue Type: Bug
Components: Validator
Reporter: goodwill

I found most of the validators still directly invoke BuildErrorMessage when apply web validation is being called. Its not correct- it should always use ErrorMessage otherwise the message being overridden by attributes would not be used at all.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://support.castleproject.org//secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Yuri (JIRA)]

[ http://support.castleproject.org//browse/COMP-23?page=comments#action_11400 ]

Yuri commented on COMP-23:
--------------------------

This issue is fixed by COMP-18.
The AbstractValidator will give the attribute message precedence over the MessageKey.

[hamilton verissimo (JIRA)]

[ http://support.castleproject.org//browse/COMP-23?page=all ]

hamilton verissimo resolved COMP-23.
------------------------------------

Assignee: hamilton verissimo
Resolution: Invalid

Yep, I think you missed the implementation of BuildErrorMessage.

> Validators should always use ErrorMessage instead of calling BuildErrorMessage directly
> ---------------------------------------------------------------------------------------
>
> Key: COMP-23
> URL: http://support.castleproject.org//browse/COMP-23
> Project: Components
> Issue Type: Bug
> Components: Validator
> Reporter: goodwill

> Assigned To: hamilton verissimo

[goodwill (JIRA)]

[ http://support.castleproject.org//browse/COMP-23?page=comments#action_11426 ]

goodwill commented on COMP-23:
------------------------------

Yep, I think its fixed sometime ago- I am sure it was wrong before, but now I checked the BuildErrorMessage routine and it looks right.

> Validators should always use ErrorMessage instead of calling BuildErrorMessage directly
> ---------------------------------------------------------------------------------------
>
> Key: COMP-23
> URL: http://support.castleproject.org//browse/COMP-23
> Project: Components
> Issue Type: Bug
> Components: Validator
> Reporter: goodwill

> Assigned To: hamilton verissimo