Patch - WcfThreadScopeInfo
0 views
Skip to first unread message
Tim Scott
Jan 31, 2009, 3:38:34 PM1/31/09
to castle-pro...@googlegroups.com
I have created a patch to add WcfThreadScopeInfo, including a config attribute of “isWcf.” I have attached to this email. Please let me know if I need to submit some other way.
I did not get as far as completely setting up the Castle build environment. I have verified that all builds and the tests that I added pass. Pretty sure there are no regressions, but please check before applying.
The one thing I was a little uncertain about is, I added a write-only property InPlaceConfigurationSource.IsRunningInWcfApp to mirror InPlaceConfigurationSource.IsRunningInWebApp. As it was the existing property could be a little confusing because it not only toggles between web mode, as the name implies, but also removes any custom thread scope info, in effect setting to the default behavior. In adding this new property, potential confusion is magnified a little because now setting either property will implicitly always set the other false, thus applying the default.
Tim
I did not get as far as completely setting up the Castle build environment. I have verified that all builds and the tests that I added pass. Pretty sure there are no regressions, but please check before applying.
The one thing I was a little uncertain about is, I added a write-only property InPlaceConfigurationSource.IsRunningInWcfApp to mirror InPlaceConfigurationSource.IsRunningInWebApp. As it was the existing property could be a little confusing because it not only toggles between web mode, as the name implies, but also removes any custom thread scope info, in effect setting to the default behavior. In adding this new property, potential confusion is magnified a little because now setting either property will implicitly always set the other false, thus applying the default.
Tim
Reply all
Reply to author
Forward
0 new messages