Issue 38 in casacore: preprocessor syntax error in casacore-1.3.0/measures/Measures/SofaTest.h:201

[casa...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 38 by fed...@gmail.com: preprocessor syntax error in
casacore-1.3.0/measures/Measures/SofaTest.h:201
http://code.google.com/p/casacore/issues/detail?id=38

What steps will reproduce the problem?
1. when building casacore, I had to use

scons --extra-cppflags=-DNEED_FORTRAN_UNDERSCORES=0

What is the expected output? What do you see instead?

Expected output is no compiler errors. However I get an error:

./measures/Measures/SofaTest.h:201:26: error: '##' cannot appear at either
end of a macro expansion

g++ --version is:
g++ (GCC) 4.1.2 20070115 (SUSE Linux)

What version of the product are you using? On what operating system?

using casacore 1.3.0 source tarball
compiling on SUSE Linux running on IBM Power 7 machine (ppc64).

Please provide any additional information below.

I managed to compile the code by changing the following lines in SofaTest.h:

#if NEED_FORTRAN_UNDERSCORES
#define IAUR(x) iau_##x##_
#else
#define IAUR(x) iau_##x##
#endif

to:

#if NEED_FORTRAN_UNDERSCORES
#define IAUR(x) iau_##x##_
#else
#define IAUR(x) iau_##x
#endif

I guess the extra token concatenator ## at the end of the line was a
remnant of some copy/pasting...

[casa...@googlecode.com]

Comment #1 on issue 38 by gervandi...@gmail.com: preprocessor syntax error

in casacore-1.3.0/measures/Measures/SofaTest.h:201
http://code.google.com/p/casacore/issues/detail?id=38

I've fixed this issue on the trunk.
I leave it to Malte to fix it in the release.

Ger

[casa...@googlecode.com]

Updates:
Status: Accepted
Owner: Malte.Marquarding

Comment #2 on issue 38 by gervandi...@gmail.com: preprocessor syntax error

in casacore-1.3.0/measures/Measures/SofaTest.h:201
http://code.google.com/p/casacore/issues/detail?id=38

(No comment was entered for this change.)

[casa...@googlecode.com]

Comment #3 on issue 38 by Malte.Marquarding: preprocessor syntax error in
casacore-1.3.0/measures/Measures/SofaTest.h:201
http://code.google.com/p/casacore/issues/detail?id=38

Is a new release necessary right now or can you wait until a later one.

[casa...@googlecode.com]

Comment #4 on issue 38 by fed...@gmail.com: preprocessor syntax error in
casacore-1.3.0/measures/Measures/SofaTest.h:201
http://code.google.com/p/casacore/issues/detail?id=38

I fixed the the typo and recompiled already. From my perspective there is
no need for a new release...

[casa...@googlecode.com]

Updates:
Status: Fixed

Comment #5 on issue 38 by Malte.Marquarding: preprocessor syntax error in
casacore-1.3.0/measures/Measures/SofaTest.h:201
http://code.google.com/p/casacore/issues/detail?id=38

fixed in trunk and will appear in the next release