quicknuke also nukes clicks

[garbuhj]

Quicknuke's function is great - but there's a big bug in it. When I
command click a link to open that link in a new tab in the background,
about every 30th option-click winds up not opening a new tab with that
link. When I turn off quicknuke, my option-clicks work 100% of the
time, but when I turn it back on I again lose around every 30th option
click. So I have to keep quicknuke turned off, even though I really
like its function. Please fix this bug so I can use quicknuke again.
Thanks!

[Chul Kim]

Hi,

I don't understand how QuickNuke could be interfering with command-clicks on links, but here: try this build that makes it so QuickNuke should always ignore clicks when you have any modifier key down (command-click, option-click, whatever). Here's the direct download link: QuickNuke124.safariextz. If that doesn't help, I think something else is interfering with your command-clicks. Do you have my LinkThing extension installed? If so, that may be the culprit.

Regards,

Chul

[bob smith]

I'm 100% certain that it's caused by quicknuke. I had quicknuke
installed for a couple of months and loved it but I was continually
having that lost-click problem a few times a day. Then I disabled
quicknuke and the problem went away and has not happened a single time
for like 6 months. Then earlier today I reenabled quicknuke and I've
had 2 lost clicks today. It's 100% definitely caused by quicknuke
being enabled. Though I suppose it's potentially possible that the
problem is caused
by a conflict between quicknuke and one of my other extensions, which
are Ad Block, Superdrag, Facebook Disconnect, Tabkeys, Social Fixer,
DKB, YTshowRating, and AllPagesZoom.

I'll try installing the quicknuke 1.2.4 extension that you linked to
and we'll see if it makes a difference. I'll report back either way.

Thanks

[Canisbos Computing]

If it happens again, try to note what link on what page failed and whether it happens repeatably.

Chul

[Canisbos (developer)]

Repeatably on the same link, that is.

[bob smith]

In the past when a click failed, I'd go click on the link a second
time and the second time it always works correctly (due to the
infrequent nature of the click failure problem). And now that I think
about it, every 30th click is probably a significant overestimate. It
would happen like 2 or 3 times a day during a total several hours of
web surfing.

[bob smith]

I'm pretty sure I saw it happen a little while ago, but because
there's no event to notice when it happens (it's merely a *lack* of an
event) it's hard to know for certain if I'm not really paying
attention to my clicks as I'm doing them. Though it's unlikely, I'll
see if maybe I can catch it on a video recording.

[bob smith]

Yup, it just happened right now.

[Canisbos Computing]

Page and link, please. Although the occurrence may seem totally random, there may be something about certain links that encourage the bug.

Chul

[bob smith]

okay. I didn't take note of the exact link. Next time it happens
I'll copy and paste it.

[Chul Kim]

Thanks. I need to know the URL of the page where the link is and a description of how to find the link, so I can check it out in place.

Regards,

Chul

[bob smith]

will do.

[bob smith]

Got it! I saved the page as a webarchive. I option-clicked (or
shift-option-clicked) link #21 (My Favorite Building in New York
City), but it didn't open in a new tab, it just turned the link purple
as if I really did click it, but nothing happened.

[bob smith]

gmail added .html to that file for some reason. Delete that extra
extension and it should open as a regular webarchive file.

[bob smith]

Dude, it just happened again on that same page. Link #19 ("Motivation
wall complete").

[Chul Kim]

Okay, time for a sanity check. That web archive wasn't any help, because native Safari extensions don't work for file:/// URLs anyway. But I did try a lot of command-clicking on reddit, and nothing anomalous happened.

Here's a direct link to another test build: QuickNuke125.safariextz. This one is designed so that the extension still loads, but no event handlers are registered. That means unless something really weird is going on, it cannot possibly interfere with any clicks. Please install this and see if you still get ignored clicks, or command-clicks that don't open a new tab. If it still happens, we're going to comment out other parts of the extension one by one until we find the goddamn part that's causing the problem—if you're game. BTW because of the unregistered event handlers, this build will not nuke anything.

Chul

Attachments:

- reddit: the front page of the internet.webarchive

[Chul Kim]

By the way, when you wrote that you option-clicked the link, you meant command-clicked, right? Because if you option-click a link, Safari will not open it—it will download the linked file instead.

Chul

[bob smith]

I'm game! I'll install the new version right now. And yeah, you're
right, I meant command click. In fact, if there's a way to disable
that option-click to download feature then I'd turn it off.

[bob smith]

I've been on vacation for the past few days, so I've been using my
computer much less than usual during the past few days, but even with
my greatly reduced amount of surfing I'm pretty sure that I haven't
seen a lost click recently in an amount of surfing where I would've
normally encountered it. So tentatively I believe it's safe to say
that the code you removed was responsible for the lost clicks.

[Chul Kim]

Hi Bob,

I've released a Quicknuke 1.2.7 update that I think will solve the problem you found. Please install it.

Regards,

Chul

[bob smith]

I just uninstalled quicknuke and then re-downloaded it from this page,
but it sent me version 1.2.5

http://canisbos.com/quicknuke

[bob smith]

... but 1.2.7 is showing up in safari's extension update page, so I'm
updating that way instead of doing a clean install of quicknuke.

[Chul Kim]

Well, I don't know what to say. Downloading from the website works fine for me.

Regards,

Chul

[bob smith]

You did it! =D

I just realized that I've been doing my normal amount of surfing for
the past few days and I haven't noticed a single lost click! Good job
man!

I'm not a programmer, so it'll probably go over my head, but I'm
curious - what was the offending bit of code, and how did you track it
down with so little information about the bug?

Thanks man. I went and dropped 5 big ones on your paypal. Treat
yourself to a cup of starbucks. ;)

[Chul Kim]

Hi Bob,

Oh, that was you? Thanks for the donation! I thought it was coming from someone else, since the name on the paypal account was different. The email address did look familiar, though…

I can't say what really fixed the problem. I just took a magnifying glass to the code and identified some places where things could have been tighter or more logical, and I rewrote those parts—specifically parts having to do with event handling. I must admit event handling is still a bit of a black art to me, but thanks to your bug-finding acumen—nobody else ever reported the same kind of problem—I'm better at it now.

Again, thanks for the donation!

Regards,

Chul

[bob smith]

Also just FYI, the font size on your automated signature is different
than the font size that you write your message text in. This looks
sloppy visually and makes it obvious that it's an automated signature
rather than a personal one.

[bob smith]

You're welcome =)

This is my spam email account, so I have a fake name in it. But now
with my credit card info you know my real name! =O ;)

[Chul Kim]

Weird. I use Sparrow. In the compose window, there is no difference in the font and size of the signature and the email body.

I've removed the auto sig. Is this better?

Regards,

Chul

Attachments:

- Screen shot 2012-03-18 at 7.22.08 PM.png

[bob smith]

Yup, now it's perfect.