[LinkThing] Conflict with internal JS events

5 views
Skip to first unread message

Rizky Syazuli

unread,
Nov 17, 2010, 11:43:12 AM11/17/10
to Safari Extensions by Canisbos
just found a bug.. turns out that LinkThing breaks some of the
javascript events on my website.
i use jquery. below is a snippet of my script. it binds all links with
the class "overlay" to run a function that opens a modal window.

$(document).bind('click', function(e) {
if ($(e.target).is('.overlay')) {
// do stuff here

e.preventDefault();
}
});

the above script fails to open the modal window :| but when i disable
LinkThing everything works just fine.

here's the URL to my site: <http://www.pocarisweat.co.id/ionopolis/>
(try clicking on the login link on the top menu)
the scripts on my site are concatenated and minified. if you need the
original source just let me know.

thx..

Canisbos Computing

unread,
Nov 17, 2010, 12:10:54 PM11/17/10
to cani...@googlegroups.com
Hi Rizky,

Ouch. I will look into this conflict asap.

Regards,
Chul

Canisbos Computing

unread,
Nov 17, 2010, 1:09:51 PM11/17/10
to cani...@googlegroups.com
Hi again,

Okay, I've traced this bug to what appears to be a brain fart of mine. For
some reason I had some code in my script that basically said, "If I should
not do anything special with this link, then set window.location to the
link URL." I have no idea now why I thought that would be better than
justing letting the click pass through!

I will release an update later today that fixes this along with a couple
of other small things.

Thanks for the bug report.

Chul


On 11/17/10 8:43 AM, "Rizky Syazuli" <br4in...@gmail.com> wrote:

Rizky Syazuli

unread,
Nov 17, 2010, 1:35:19 PM11/17/10
to Safari Extensions by Canisbos
that's awesome..

it hasn't been long since i disable it, but i already miss the
functionality :D
great job man.. looking forward for the next release..

thx

Canisbos Computing

unread,
Nov 17, 2010, 2:14:39 PM11/17/10
to cani...@googlegroups.com
Fixed in LinkThing 1.0.6.

On 11/17/10 8:43 AM, "Rizky Syazuli" <br4in...@gmail.com> wrote:

Rizky Syazuli

unread,
Nov 26, 2010, 4:09:55 AM11/26/10
to Safari Extensions by Canisbos
nice!! but I've noticed something else that's probably a bug :P
links inside gmail (which normally opens in a new window) now opens
two tabs/window at once. i haven't spot this issue on other sites yet,
but you might wanna check it out.


On Nov 18, 2:14 am, Canisbos Computing <canis...@gmail.com> wrote:
> Fixed in LinkThing 1.0.6.
>
> On 11/17/10 8:43 AM, "Rizky Syazuli" <br4inwas...@gmail.com> wrote:
>
>
>

Canisbos Computing

unread,
Nov 26, 2010, 1:00:13 PM11/26/10
to cani...@googlegroups.com
Hi Rizky,

Thanks for spotting the bug. An update has been released.

Regards,
Chul

Reply all
Reply to author
Forward
0 new messages