Venue Improvements!
Reid Beels
Audrey and I met up yesterday and worked on a few improvements to Calagator's venues. We'd appreciate code review and feedback.
The Changes!
===========
* Improved the layout of the venue show page.
* Added a "closed" flag to denote venues which are out of business. It's a boolean and defaults to true. There are named scopes (in_business and out_of_business) for accessing venues in either state of closedness. Closed venues are not shown in the ajax venue picker and are called out on venue and event show pages.
* Added a "wifi" flag to denote venues which offer public wifi. There's a with_public_wifi named scope for getting at WiFiful venues.
* Simplified the new venue form to not show detailed address fields for new records, instead encouraging users to enter the full address and let geocoding take care of the rest.
* Added an "access notes" text field to the new venue form to hold specific information about building access. This is called out with an icon on the venue show page and is included on event pages (unlike the venue description, which is not shown there)
* Added a new default state for the venues index that shows the 10 most active venues (via a new events_counter counter_cache column on venues), 10 newest venues, and a search form. Links are provided to list all venues, show a map and download venue data as KML or JSON.
* Added several search options to VenuesController. These are currently using slow SQL "like" searching and should probably be switched to use the new pluggable search awesomeness soon.
And some smaller ones:
* Added specs for VenuesController search mechanism
* Truncated the display of long URLs on venue show pages, as these could cause wrapping strangeness.
* Added named scopes for finding marked_duplicates and non_duplicates for models that include DuplicateChecking
The Code!
========
We built a with_venue_enhancements branch on top of calagator/with_pluggable_search
https://github.com/calagator/calagator/tree/with_venue_enhancements
You can see the commits we added at:
https://github.com/calagator/calagator/compare/with_pluggable_search...with_venue_enhancements
Screenshots!
==========
Reid Beels
On Feb 20, 2011, at 6:11 PM, Reid Beels wrote:
> * Added a "closed" flag to denote venues which are out of business. It's a boolean and defaults to true. There are named scopes (in_business and out_of_business) for accessing venues in either state of closedness. Closed venues are not shown in the ajax venue picker and are called out on venue and event show pages.
This flag actually defaults to false, not true. Venues are, in fact, open by default.
Reid