Fatal Error Handler

[Juan Basso]

Hi guys,

I implemented a new handler to catch fatal errors.

code: https://github.com/jrbasso/cakephp/compare/cakephp:2.2...2.2-fatal-error

docs: https://github.com/jrbasso/docs/compare/cakephp:2.2...2.2-fatal-error

By default it will show a page like missing something, but showing the fatal error message, with the file and line that it happened. If debug is disabled, it will show internal server error page.

What you think?

Juan Basso

[euromark]

+1

I like it that there will be a build in fatal error handler soon.

as of right now one would have to apply some self-coded hack to catch and log those.

I used to do it this way:

register_shutdown_function('shutdownFunction');

function shutDownFunction() { //manual logging }

[José Lorenzo Rodríguez]

Nice work Juan!! I think it is ready to be merged :)

Sent from my iPhone

[mark_story]

Great work Juan!  I added a few comments to the docs commits.  I guess I should better document the new console handler better as well. :)

-Mark

[Juan Basso]

Thanks! As the core.php use the same text, I also updated.

Juan Basso

[Juan Basso]

After talk with Mark, the code was changed. I removed the Error.fatalErrorHandler from configuration and the regular Error.handler will receive the fatal error codes as well. The handler will define what should be the behavior for this situation.

Code and doc updated.

Juan Basso

[ADmad]

On a related note in 2.2 I had updated ExceptionRenderer to use a separate 'error' layout instead of 'default' layout when rendering "safe" messages in case of repeated errors/exceptions 0832e18e9e refs #2682

Then recently I again updated it to always use 'error' layout instead of 'default' 3495422ac5. I wanted to get everyone's opinion if this is good or it should be reverted back to using error layout only when rendering "safe" messages in case of repeated errors.

-ADmad

[majna]

Assuming that NotFoundException will render "error" layout with this change in 2.2;
it is common for 404 error pages to have menus or footer like this https://github.com/blablba
so you have to duplicate code from "default" layout in "error" layout and you end up with same problem in case of repeated errors.

On Tuesday, April 3, 2012 9:15:25 PM UTC+2, ADmad wrote:

On a related note in 2.2 I had updated ExceptionRenderer to use a separate 'error' layout instead of 'default' layout when rendering "safe" messages in case of repeated errors/exceptions 0832e18e9e refs #2682

Then recently I again updated it to always use 'error' layout instead of 'default' 3495422ac5. I wanted to get everyone's opinion if this is good or it should be reverted back to using error layout only when rendering "safe" messages in case of repeated errors.

-ADmad

On Monday, April 2, 2012 9:38:38 AM UTC+5:30, Juan Basso wrote:

After talk with Mark, the code was changed. I removed the Error.fatalErrorHandler from configuration and the regular Error.handler will receive the fatal error codes as well. The handler will define what should be the behavior for this situation.

Code and doc updated.

Juan Basso

[Renan Gonçalves]

Good point.

Also I don't see myself in need of a different layout in case of a error, only if its a authentication/authorization error.

But if what you want is a "temporarily" error page, there is already flash.ctp for it.

--
Renan Gonçalves aka renan.saddam
Software Engineer at TrueServer B.V.
CakePHP Core Developer
Website: renangoncalves dot com
Amsterdam, The Netherlands

[mark_story]

ADmad:  I would think the error layout would only be used for repeat errors or errors encountered when rendering an error.  Having it used for all errors means people will put their app helpers into it.  This means that repeat errors will continue to fail fatally.

-Mark

[ADmad]

Ok guys I will revert the change and use error layout only in ExceptionRenderer::_outputMessageSafe() as i had initially done.

-ADmad

[Ceeram]

Fatal errors should also use error layout.

$helpers = array('Good', 'Bad');

when BadHelper produces fatal, the default layout will cause another error when calling method on non-object GoodHelper, which will hide the original fatal error. In the stack trace only i can see the FatalError handler is starting point, not what the original fatal error was. quick fix was adding $this->layout = 'error'; to the fatal_error.ctp view

Op donderdag 5 april 2012 21:13:07 UTC+2 schreef ADmad het volgende:

[mark_story]

Sounds like a good idea, do you want to make that change Ceeram?

-Mark

[Ceeram]

Sure, setting layout in the view file is ok?

Op 21 apr. 2012 03:18 schreef "mark_story" <mark....@gmail.com> het volgende:

[Ceeram]

After looking again, i see error layout is in app dir only, perhaps fatal error even use no layout to avoid other issues?

Op zaterdag 21 april 2012 10:58:48 UTC+2 schreef Ceeram het volgende:

[ADmad]

View class uses bake skel as fallback for files, so if you don't have error layout in your app the one from bake skel will be used.