Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
The tagging app really should be upgraded, but that currently breaks other things, so for the time being, backport http://code.google.com/p/djang o-tagging/source/detail?r=172 which is the fix for http://code.google.com/p/djang o-tagging/issues/detail?id=233 This allows byteflow to work with Django 1.2
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  2 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Peter Nixon  
View profile  
 More options May 19 2010, 11:21 am
From: Peter Nixon <listu...@peternixon.net>
Date: Wed, 19 May 2010 18:21:18 +0300
Local: Wed, May 19 2010 11:21 am
Subject: [PATCH] The tagging app really should be upgraded, but that currently breaks other things, so for the time being, backport http://code.google.com/p/django-tagging/ source/detail?r=172 which is the fix for http://code.google.com/p/django-tagging/ issues/detail?id=233 This allows byteflow to work with Django 1.2
# HG changeset patch
# User Peter Nixon <listu...@peternixon.net>
# Date 1274281992 -10800
# Node ID 8883ca08318270ea981ed5ac13537d2df8697802
# Parent  5b6d964917b5deb5af17fa8293f5f63038765b9c
The tagging app really should be upgraded, but that currently breaks other things, so for the time being, backport http://code.google.com/p/django-tagging/source/detail?r=172 which is the fix for http://code.google.com/p/django-tagging/issues/detail?id=233 This allows byteflow to work with Django 1.2

diff --git a/apps/tagging/managers.py b/apps/tagging/managers.py
--- a/apps/tagging/managers.py
+++ b/apps/tagging/managers.py
@@ -153,8 +153,19 @@
         greater than or equal to ``min_count`` will be returned.
         Passing a value for ``min_count`` implies ``counts=True``.
         """
-        extra_joins = ' '.join(queryset.query.get_from_clause()[0][1:])
-        where, params = queryset.query.where.as_sql()
+
+        if getattr(queryset.query, 'get_compiler', None):
+            # Django 1.2+
+            compiler = queryset.query.get_compiler(using='default')
+            extra_joins = ' '.join(compiler.get_from_clause()[0][1:])
+            where, params = queryset.query.where.as_sql(
+                compiler.quote_name_unless_alias, compiler.connection
+            )
+        else:
+            # Django pre-1.2
+            extra_joins = ' '.join(queryset.query.get_from_clause()[0][1:])
+            where, params = queryset.query.where.as_sql()
+
         if where:
             extra_criteria = 'AND %s' % where
         else:


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Alexander Solovyov  
View profile  
 More options May 20 2010, 11:03 am
From: "Alexander Solovyov" <pira...@piranha.org.ua>
Date: Thu, 20 May 2010 18:03:13 +0300
Local: Thurs, May 20 2010 11:03 am
Subject: Re: [PATCH] The tagging app really should be upgraded, but that currently breaks other things, so for the time being, backport http://code.google.com/p/django-tagging/ source/detail?r=172 which is the fix for http://code.google.com/p/django-tagging/ issues/detail?id=233 This allows byteflow to work with Django 1.2
On 2010-05-19, Peter Nixon wrote:

> # HG changeset patch
> # User Peter Nixon <listu...@peternixon.net>
> # Date 1274281992 -10800
> # Node ID 8883ca08318270ea981ed5ac13537d2df8697802
> # Parent  5b6d964917b5deb5af17fa8293f5f63038765b9c
> The tagging app really should be upgraded, but that currently breaks other things, so for the time being, backport http://code.google.com/p/django-tagging/source/detail?r=172 which is the fix for http://code.google.com/p/django-tagging/issues/detail?id=233 This allows byteflow to work with Django 1.2

Thanks, applied and pushed.

--
Alexander


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »