new Release with all your changes?

[Klaas Reineke]

Hi,

just a question: is it time for a new release with all your changes?
There have been a lot of changes, maybe there should be a new release
with all the new stuff? I have no idea if Toby can add a release on
sourceforge I am pretty certain but not sure.

Regards Klaas

[Toby Dickenson]

Yes at some point we need a new release, but I am hoping to fix the not-quite-
gapless bug first.

--
Toby Dickenson

[Olav Sunde]

I am also looking forward to a new release. I've been working on a
modification of the plugin html to enable support for non-character
based players. A friend at work is helping me get the programming
done, but he is rather busy at the moment so this takes more time than
planned. It would be nice to have this approved for the next release,
but can also be added later.

Olav

[Olav Sunde]

On Mar 24, 10:27 pm, Olav Sunde <ogsu...@gmail.com> wrote:

>
> I've been working on a
> modification of the plugin html to enable support for non-character
> based players.

Hi all,

I now have a working version of this in my installation. In a week or
so I'll be able to send this to the group for testing.

Olav

[Olav Sunde]

I now have version "0.98" of the filter selector in use on my SBS.
Roger Johansen has written the code. To a large extent he makes use of
functions already available in SBS and the plugin so the code does not
break with the way things work in the present version. Roger has used
Vortexbox while developing the code. My installation is running on a
Netgear Readynas Ultra 2 Plus (works extremely well).
During testing I've noticed that equalizer configurations with
Brutefir no longer work. I will send sample filter configs to Toby in
PM so he can check what has happened.
Roger will work a little more on the user interface before I mail the
changed files to the group for testing.

Olav

[Olav Sunde]

I have mailed a zip file with Settings.pm, Plugin.pm, stings.txt and
basic.html to group menbers.
To test you need to disable the plugin, copy new files to their
respective folders, then re-enable the plugin. When using the
'Default' web interface the plugin will populate the drop-down boxes
for a player with it's current settings via some java script code. In
'Classic' (which I use most of the time for speed..) java script is
not handled properly so the drop-down will revert to '#..#' in stead.
I have not tested the other skins.
A staus line for each player will always be shown below the drop-down
settings.

Klaas: New items in strings.txt need translation to German.

Olav

[Olav Sunde]

No feedback on this one? I was hoping to see at least some interest...
I suppose you all have tweaked your setup so it may be difficult to
just replace the plugin with a modified one, but still..?

Olav

[Toby Dickenson]

I am interested, but have had zero free time over the last week to look at
anything. I blame busy work and unexpectedly sunny British weather. My setup
is entirely standard, so dropping this in should not be a problem.

Thanks for the reminder.... I will definitely give this some attention as soon
as possible, but dont want to make any promise about when this will be.

--
Toby Dickenson

[Olav Sunde]

On Apr 17, 1:05 pm, Toby Dickenson <t...@tarind.com> wrote:

> anything. I blame busy work and unexpectedly sunny British weather.  My setup
> is entirely standard, so dropping this in should not be a problem.

No problem at all Toby!

I hope the sunny British weather continues.. My wife an I will spend
Easter in Torquay this year.

:>)

Olav

[Mervin Beng]

Hi Olav,

I'm a Touch user, so I only have control of the filters via config files ;(. Does anyone have plans on moving the other parts of of brutefirdrc to the SB Touch? ;)

[Olav Sunde]

On Apr 18, 12:29 am, Mervin Beng <merv...@mail.com> wrote:
> Hi Olav,
>
> I'm a Touch user, so I only have control of the filters via config
> files ;(. Does anyone have plans on moving the other parts of of
> brutefirdrc to the SB Touch? ;)
>
>
>

Hi Mervin,

I also use the Touch. My plan for the change is to enable selection of
filter and template for a given player and then enable this for
BrutefirDRC in the web interface rather than Linux CLI. The nice thing
is that a change is done on-the-fly so the next track you play has the
new setting. No need to restart SBS. You will still have to manage
content of config files manually unfortunately. Users of Transporter/
Classic SB's can still use the menu system on the player plus the new
selector in the web UI.
As Klaas says, reworking the plugin to work in the graphic UI's is a
major job.

[Klaas Reineke]

Hi Olav,

I am sorry as well. Since we have our kid, I have not time for all
this nice stuff anymore. I even moved my speakers around and did not
measure the room again :(

But I have it on my todo list and will swap your source in. I am
really glad, that you did this, because some people ask to do it in
the web interface. So after testing we should push a new release with
all the changes!

Regards Klaas

[Olav Sunde]

On Apr 18, 9:25 am, Klaas Reineke <klaas.rein...@googlemail.com>
wrote:

> Hi Olav,
>
> I am sorry as well. Since we have our kid, I have not time for all
> this nice stuff anymore. I even moved my speakers around and did not
> measure the room again :(

A child is ultimately more important than any hobby, even music!

>
> But I have it on my todo list and will swap your source in. I am
> really glad, that you did this, because some people ask to do it in
> the web interface. So after testing we should push a new release with
> all the changes!

Good, looking forward to your findings. I am a little uncertain if the
new code can pick up settings for an already enabled player correctly.
I know Roger store things in server.prefs for the new part, but the
menu-system on a SB Classic does this too? Anyway, after saving a
setting the first time with the new selector all seem to work fine.

Olav

[Olav Sunde]

I checked with Roger. He uses ...prefs/plugin/brutefirdrc.prefs for
saving settings. server.prefs is not used for any settings.

Olav

[Toby Dickenson]

On Sunday 17 Apr 2011, Toby Dickenson wrote:
> On Sunday 17 Apr 2011, Olav Sunde wrote:
> > No feedback on this one? I was hoping to see at least some interest...

> I am interested, but have had zero free time over the last week

I do keep seeing this on my todo list and thinking I might have time later
that day, but another month has gone by and I still havent :-( I just wanted
to let you know it isnt forgotten.

--
Toby Dickenson

[Olav Sunde]

On May 24, 8:59 pm, Toby Dickenson <t...@tarind.com> wrote:
>
> I do keep seeing this on my todo list and thinking I might have time later
> that day, but another month has gone by and I still havent :-( I just wanted
> to let you know it isnt forgotten.
>

Thanks Toby..

I have not had any time to even play music lately so don't worry :>)
Summer is not the best time for this type of activity anyway..

Olav

[Toby Dickenson]

Finally a rainy day. Olav's patch seems to work as described, and it is now in
git. I will take a more detailed look later this week, and think about making
a proper release with all these changes.

Thanks for everyones contributions and patience.

--
Toby Dickenson

[Olav Sunde]

Hi all, just a test to see if posts work from the new user interface of Google Groups. I responded to Toby from the old UI. That did not seem to work.

Olav

[Olav Sunde]

Hi,
I tried to install the plugin in the new LMS 7.7 today (Vortexbox 2.0)  The plugin is not compatible with LSM it seems. So what do we do about this?
I hope to have the filter select code fixed for the old version by next week, but the change in LMS is unexpected an a bit dissapointing.

[Mervin Beng]

Hi Olav,

I've tried installing LMS 7.7 on Arch Linux, and it is basically working (others had reported issues), but I had not done a complete installation (no plugins, no filters, just ran the server as a normal user). The timing of your message is great, as I was planning to move to 7.7 in the coming weeks. I found the library scanning much improved on 7.7.

Is there any documentation on changes in the plugin architecture for 7.7? What is the detault python version on Vortext 2.0?

Kind regards,
Mervin

 

----- Original Message -----

From: Olav Sunde

Sent: 11/16/11 01:39 AM

To: brute...@googlegroups.com

Subject: Re: new Release with all your changes?

[Olav Sunde]

Hi Mervin,

I am using a Readynas Ultra2 Plus an had planned to upgrade to LMS 7.7. Now I'll wait until the problem with BrutefirDRC is hopefully sorted.

I know Fedora14 came with python 2.7 but I do not know Fedora16/Vortexbox2.0 (I have packed away my test laptop again..)
For changes in plugin architecture, this thread have a few hints to changes http://forums.slimdevices.com/showthread.php?t=84596 It may not be all that difficult to re-write the code.

Olav

[Mervin Beng]

My first thought is that F16 (Vortex 2.0) might be defaulting to Python3, which will have minor issues with the brutefirwrapper.

[Olav Sunde]

You may be right. I'll check which version Python is. I also believe the plugin install needs updating as the error message turned up where you enable/disable plugins in LMS. Something like "..plugin not compatible with this version of LMS, please update" 

[Mervin Beng]

Hi Olav,

For a start, the install.xml needs to be update in the plugin directory for Brutefirdrc.

<maxVersion>7.7+</maxVersion>

When I did this and restarted the server, I could see the plugin and even go to its configuration page. I haven't gone further, as I'm still running it as a normal user in my home directory, so I have to copy filters and set it up to test. For the wrapper, if Fedora16 uses Python3, then you can try changing the first line:

#! /usr/bin/python2

Regards,
Mervin

[Olav Sunde]

Thanks Mervin,

I partly found this info too yesterday. I'll see if I can find some time for testing this evening and change install.xml and brutefirwrapper.

Olav

[Olav Sunde]

Good  news! BrutefirDRC works with LMS 7.7.x on Vortexbox 2.0.
By changing the version info in install.xml to <maxVersion>7.7+</maxVersion> the plugin installs correctly. Python is v 2.7.2 and is linked to /usr/bin/python so no problems in brutefirwrapper either.

Olav

[Mervin Beng]

I think you'll find that the custom-convert.conf that creates the brutefir pipeline doesn't work. When I set up 7.7, the SBT receives a standard flac stream instead of the DRC'd stream. This is going to be a little more difficult to troubleshoot.

Mervin

[Olav Sunde]

Playback with BrutefirDRC + PCM sent to my Touch works as far as I can see. Top shows the right processes and log output from brutefirwrapper (rew 9) is good. I have not tested flac -> Touch streaming yet.

Olav

[Toby Dickenson]

cc list too

---------- Forwarded message ----------
From: Toby Dickenson <to...@tarind.com>
Date: 21 February 2012 20:08
Subject: Re: new Release with all your changes?

To: Olav Sunde <o...@olavsunde.net>

> long time with little activity from my part. Today I finally got to work
> with Roger (who is now living in Oslo) to check that the changes he made to
> the plugin some time ago works as expected. Please find attached the new
> files.

Thanks. I will review this weekend. I also had some uncommitted
changes which I thought fixed the problem - it will be interesting to
see if Roger's changes are similar.

> I believe at least one of the issues you mention has been fixed. Not quite
> sure about changes made on an SB2/3 will turn up in the web UI or the other
> way around.
>
> I expect you have been busy lately as there has been no activity on the
> plugin list. Will you get a chance to do further work on brutefiwrapper?

Well, I finally managed to move house so now have lots of priorities
ahead of brutefirdrc. I dont even have brutefirdrc enabled any more,
and dont expect to be able to take any room correction measurements
for a while :-(

Any volunteers to package the current code into a release?

[Olav Sunde]

Hi Tony,

I am currently running brutefirwrapper v9. Have you done any work on the wrapper since then? Eq function in brutefir is broken and there is still the issue with noise during track transitions. I believe Tony is the only one that can fix things in the wrapper. Packaging a new version when all is working may not be that difficult. I don't think I am the right one for this though. How about you Klaas? Some text in strings.txt added for the new filter select code needs translation to German..

[Olav Sunde]

Toby, sorry for writing Tony! To quick on the 'post' button...

Olav

[Toby Dickenson]

On 24 February 2012 11:07, Olav Sunde <ogs...@gmail.com> wrote:

> I am currently running brutefirwrapper v9. Have you done any work on the
> wrapper since then?

I think that is a sign that your changes have not been based on the
latest version. Ive had a quick review of your updates and they do
seem to be based on something older. Unfortunately I dont have the
time right now to track this down.

> and there is still the
> issue with noise during track transitions.

There is a v10 of brutefirwrapper in git. Those differences are not
particularly interesting, but there are some changes to the
custom-convert template files which might fix your noise on track
transitions if you are streaming in pcm. Sorry, I thought you already
had these fixes :-(

On 21 February 2012 20:08, Toby wrote:

> I also had some uncommitted changes which I thought fixed the problem

Those changes I mentioned were made last September. They seem to work
- filter changes are visible across web and SB3 - but were not
committed because they needed tidying up. Ive definitely run out of
time for that now, so I have committed them to git as is.

http://brutefirdrc.git.sourceforge.net/git/gitweb.cgi?p=brutefirdrc/brutefirdrc;a=co
mmitdiff;h=68d6941ae6792fe621f518b52d13cf5e05b9426f

I'm sorry I didnt get a chance to wrap this up neatly before
priorities changed. Over to you.

[Olav Sunde]

Hi Toby,

as you say v10 does not change behavior during track transitions. I do have the newest custom-convert template files.
Have not yet tested your version of the filter-select function. I'll get back to that.

I may have found something that prevents use of equalizer. Part of brutefir.log below: 

======== brutefirwrapper rev 10 starting at 1330433506 2012-02-28 12:51:46
Resampling brutefir filter from 96000 to 44100
Patching brutefir input format from S24_LE to S16_LE
Patching brutefir output format from S24_LE to S16_LE
Traceback (most recent call last):
  File "/usr/share/squeezeboxserver/Plugins/BrutefirDrc/Bin/brutefirwrapper", line 437, in read_tail
    age = time.time()-os.stat(tail_filename).st_mtime
OSError: [Errno 2] No such file or directory: '/tmp/.BrutefirDrc-0/tail-00_04_20_22_28_3a.pcm'
Output follows (0.413s)

BruteFIR v1.0k (March 2009)                                   (c) Anders Torger

Parse error on line 26 in file "/tmp/.BrutefirDrc-0/filter-00_04_20_22_28_3a-00_04_20_22_28_3a-44100-S16_LE":
  unrecognised token.
Output complete (0.431s)

--------------------------------------------------

line 26 in the temporary file is this:

                dirac pulse

compared to line 26 in the original config:

                "dirac pulse"

so it seems the quotes are stripped when brutefirwrapper writes the temporary filter.

This makes sense as files with the same sample rate as defined in the configured filter plays fine, i.e if sampling_rate: 96000 then a 96kHz file will play with EQ or EQ+filter enabled (using the original config file), but modified filters will not play due to the above parsing error.

Olav

[Olav Sunde]

I've studied this a little more.
There are three instances filename: in the original config file. Two lines must be patched for resampling. These contain paths to the l and r pcm files.

The third, present when the config file contains equalizer

coeff "equalizer" {
        filename: "dirac pulse";
        shared_mem: true;
        blocks: 4;
};

should be left alone for brutefir to read the config correctly.

If this can be fixed I believe we have the equalizer issue out of the way.

[Toby Dickenson]

Try this:

diff --git a/BrutefirDrc/Bin/brutefirwrapper b/BrutefirDrc/Bin/brutefirwrapper
index bde8824..fee8e37 100755
--- a/BrutefirDrc/Bin/brutefirwrapper
+++ b/BrutefirDrc/Bin/brutefirwrapper
@@ -205,7 +205,7 @@ def patch_samplerate(filter_body,samplerate):
def resample_filter(original):
source_pcm_filename = original.group(1)
if source_pcm_filename == 'dirac pulse':
- return source_pcm_filename
+ return 'filename:"dirac pulse";'
output_pcm_filename = os.path.split(source_pcm_filename)[1]
output_pcm_filename = '%s-%d' % (output_pcm_filename,samplerate)
output_pcm_filename = os.path.join(TMPDIR,output_pcm_filename)

[Olav Sunde]

Hi Toby,

this works. Thanks a lot. Much appreciated!
Brutefir seems to use some more time between tracks in a playlist with songs from several albums when using the EQ function. I see a lot of "Creating inverse inplace FFTW plan of size xxxxx using wisdom...finished". A single album plays OK. I need to check more on this.

[Olav Sunde]

Good news!

I have tested triode's Enhanced Digital Output (EDO) plugin with my Touch and BrutefirDRC. This works! I can play all sample rates up to 192kHz. My DAC is connected with S/PDIF coax. No errors from brutefirwrapper or brutefir and resampling of filter is performed correctly by brutefirwrapper.
I have tried it on a Vortexbox installation and my Readynas Ultra 2 plus. First I used the current release of LMS and firmware v7.7.2. With this I could send FLAC (Native) to the player for rates higher than 96kHz. I then upgraded to v7.8 beta on server and Touch. This version enables PCM playback for 176.4 and 192kHz (embeds sample rate data for 176.4 and 192kHz into the PCM stream for the DAC to read). The plugin works fine with v7.8, but the version reported by install.xml must be corrected to reflect the LMS version before installation.
 


After Toby fixed brutefirwrapper (rev10) for equalizer support some months ago there are just two functional issues left to deal with in the current development of BrutefirDRC.

# When streaming PCM there is a short period of noise during track transitions. For FLAC and mp3 this is not an issue.

# Down sampling of sample rates higher than supported by a given player does not work properly through brutefirwrapper/sox for any streamed format.

I currently use the filter select HTML code written by Roger and me. It is absolutely stable. I have not tried Toby's version if this.

Toby: do you see any chance of working with brutefirwrapper this autumn?

Olav

[Klaas Reineke]

Hi there,

I just had the time to setup BrutefirDRC again and would like to make a new release with all the changes from Toby and Olav. I got a problem with the new files from the Git-Repository. The Strings.txt is not working anymore. Not within the webpage nor within the old interface for the squeezebox3.

Is the strings.txt working for someone else, i.e. is the correct name showing in the Plugins page or is it the key=PLUGIN_BRUTEFIR_DRC?

I try to figure it out, but if someone has an idea, I could provide a new release :)

Regards Klaas

[Olav Sunde]

Good to hear from you Klaas.

I have not seen the strings.txt error you describe. Apart from the new lines added as descriptions for the filter select that need translation from English, I have not seen any issues



Olav

[Olav Sunde]

I just sent Klaas a zip of the files used in the installation described above.


Olav

[Klaas Reineke]

The zip file is working. The strings.txt is displayed. I commited the changes to GIT, changed the install.xml to work with 7.7+ and added the missing german translations. The web gui is not working for me. I have my filters within subfolders, it is not possible to select those. Without subfolders everything works fine so that I could create a new release.

Is there any more uncommited work?

Regards Klaas

[Olav Sunde]

On Thursday, 9 August 2012 13:07:17 UTC+2, Klaas Reineke wrote:

The zip file is working. The strings.txt is displayed. I commited the changes to GIT, changed the install.xml to work with 7.7+ and added the missing german translations. The web gui is not working for me. I have my filters within subfolders, it is not possible to select those. Without subfolders everything works fine so that I could create a new release.

Is there any more uncommited work?

I have none. Will you be including the sample configs and null filter in the new release? Any thing in from Toby yet?

[Olav Sunde]

Hi Klaas. Any progress on releasing the new version? Unfortunately Logitech has defined EOL for Squeezebox. Maybe this will mean a new life for Squeezeboxserver? Who knows... Anyway I think BrutefirDRC is important, as room correction is getting wider appeal. We should try to get the new version out soon.

Olav