IE clips OL numbers?
Christian Montoya
If you have IE 6 or 7 on Windows and a bit of free time, I'd like to
ask you to read this bug report:
See the attached screenshot:
http://blueprintcss.lighthouseapp.com/projects/15318/tickets/15/a/72883/Screenshot.png
And let me know if you have ever observed the same thing, or if you
know of a fix. I think we just need to modify the padding in IE, but I
am having trouble testing IE at the moment.
--
--
Christian Montoya
mappdev.com :: christianmontoya.net
rebus_
>
> Hello all,
>
> If you have IE 6 or 7 on Windows and a bit of free time, I'd like to
> ask you to read this bug report:
>
> http://blueprintcss.lighthouseapp.com/projects/15318/tickets/15-ie-clips-the-numbers-in-an-ordered-list
>
> See the attached screenshot:
>
> http://blueprintcss.lighthouseapp.com/projects/15318/tickets/15/a/72883/Screenshot.png
>
> And let me know if you have ever observed the same thing, or if you
> know of a fix. I think we just need to modify the padding in IE, but I
> am having trouble testing IE at the moment.
>
In screen.css we have
li ul, li ol {margin:0 1.5em;}
ul, ol {margin:0 1.5em 1.5em 1.5em;}
and padding is set to 0 with reset CSS.
-----------------------------------------------------------------------------
By default ordered lists have padding-left:40px; and
list-style-position:outside; set which puts enumeration outside the
content area and into the padding area.
In BP margins are used (1.5em which is 18px) to push the list from the
left to create space for numerals but only one digit fits in that
amount of spave.
Stuff that overflows is not visible in IE6 for some reason (bug
maybe?) and will not be visible in other browsers if you use for
example overflow:hidden property on parent elements and have more then
9 items in list.
-----------------------------------------------------------------------------
One way of dealing with this would be setting 3.333em (is 40px @ 75%
font-size) padding on the left side of lists instead of margin (left
should be set to 0) giving plenty of space to hold two and three digit
numbers.
This goes well with default column width too.
ol, ul {margin-left:0;padding-left:3.333em}
-----------------------------------------------------------------------------
Another solution would be to set list-style-position:inside; in
screen.css thus making browsers render enumeration inside of content
area.
ol {list-style-position:inside;}
-----------------------------------------------------------------------------
With both solutions you would want to remove this property from ie.css
as it would not be necessary anymore.
ol {margin-left:2em;} added @ a5f7d0bf142b Fixed incorrect ol margin in IE6/7.
-----------------------------------------------------------------------------
I've done some test with IE6 and both fixes seem to work ok, but i'll
try to test other IE versions and browsers at work over the weekend
and if it seems ok i can push the changes to github.
--
I for one welcome our Oracle overlords.
rebus_
weeks. I was planing on doing it tomorrow and pushing it to github if
you haven't fixed it already.
Any ideas about which fix to use (padding or list-style) would be appreciated.
Thanks,
Davor
rebus_
I've pushed the fix [1] for #15 [2] to github. Decided to go with left
padding solution.
Also removed nested list left and right margins. Left margin is not
necessary because of left padding and IMHO the right one only takes up
space since the parent list already has 1.5em margin. If core devs
don't agree it can be put back easily.
This is tested on FF 3.5.2, IE6 and IE7 on Windows SP SP2 and FF
3.5.3, SeaMonkey 1.1.17, Opera 10 on linux.
Should i send pull request to joshua on github?
[1] http://github.com/rdavl/blueprint-css/commit/306b46e554bcdaae51454f491795ae9c51dffb1b
[2] http://blueprintcss.lighthouseapp.com/projects/15318-blueprint-css/tickets/15
davor
Christian Montoya
>
> Hi,
>
> I've pushed the fix [1] for #15 [2] to github. Decided to go with left
> padding solution.
>
> Also removed nested list left and right margins. Left margin is not
> necessary because of left padding and IMHO the right one only takes up
> space since the parent list already has 1.5em margin. If core devs
> don't agree it can be put back easily.
>
> This is tested on FF 3.5.2, IE6 and IE7 on Windows SP SP2 and FF
> 3.5.3, SeaMonkey 1.1.17, Opera 10 on linux.
>
> Should i send pull request to joshua on github?
>
Yes, all pull requests should always go to joshuaclayton /
http://github.com/joshuaclayton
rebus_
> Yes, all pull requests should always go to joshuaclayton /
> http://github.com/joshuaclayton
>
> --
> --
> Christian Montoya
> mappdev.com :: christianmontoya.net
done
Tim Rijkse
Regards,
Tim Rijkse
======================================\\
Tim Rijkse ; Code Monk
MediaMonks BV ; Interactive Art
Schapenkamp 2 | 1211 PA | Hilversum
The Netherlands | Europe
email : ti...@mediamonks.com
tel : +31 (0) 35 6212150
fax : +31 (0) 35 6242720
internet address : http://www.mediamonks.com
============================================||
* Member of the Creative Brotherhood.
============================================||
* Please quote all replies in correspondence.
============================================||
DISCLAIMER
De informatie in dit e-mailbericht is vertrouwelijk en uitsluitend bestemd voor de geadresseerde. Indien dit e-mailbericht niet voor u bestemd is, verzoeken wij u vriendelijk het e-mailbericht aan de afzender te retourneren, het te vernietigen en de inhoud ervan aan niemand openbaar te maken. MediaMonks B.V. aanvaardt geen enkele aansprakelijkheid voor onjuiste, onvolledige dan wel ontijdige overbrenging van de inhoud van een verzonden e-mailbericht, noch voor door haar daarbij overgebrachte virussen.
The information contained in this e-mail is confidential and intended for the addressee only. If you have received it in error please notify the sender by return e-mail. Please delete this e-mail and do not disclose its contents to any person. MediaMonks B.V. does not accept any liability for any errors, omissions, delays of receipt or viruses in the contents of this message which arise as a result of e-mail transmission.
rebus_
> Please don't contact me for BluePrint details, you can contact Sirokai
what do you mean?
if you are talking about github, some people are automatically
selected in the pull request list and i haven't noticed it till now.
Christian Montoya
OK, I am closing this thread right now, any more replies will get the
user moderated.
rebus_ created a pull request on Github, and this went out to all
those who have cloned the project in the past, which is why Tim was
contacted. No need to then send *another* message to the list, asking
not to be contacted, after receiving an automated message from a
server farm.
And no need to then send *another* message to the list, asking why.
This thread should have gone off the list long ago, and so I'm going
to say it once:
*** if you have a direct question for a single person, change the
"to:" section of your email and send it directly to that person, not
to the list. ***
Trust me, I don't mind receiving emails directly. It's all the same to
me. But there are a lot of people on this list and they don't want to
hear small questions directed at me, if they don't have to do with
actual Blueprint issues.
So no more replies to this thread, and let's be more considerate from
here on! That goes for me too!
p.s. have a good weekend, get outside, enjoy some sunshine while it lasts!
rebus_
Ticket should be closed, joshua commited the fix for it in:
http://github.com/joshuaclayton/blueprint-css/commit/016c9114f1aa91f84c3d68f3be9a97a114334d84
davor