Error on editing groups

[Claudia Jürgen]

Hello,

on both the master and i18n branch I get an internal error when trying
to change the name of a group with memberships and works associated.

groups/10-Lehrstuhl_I_Analysis

Completed 500 Internal Server Error in 468ms

ActiveRecord::ReadOnlyRecord (ActiveRecord::ReadOnlyRecord):
app/models/work.rb:385:in `set_for_index_and_save'
lib/solr_updater.rb:17:in `reindex_associated_works'
lib/solr_updater.rb:16:in `reindex_associated_works'
lib/solr_updater.rb:6:in `reindex_after_save'
app/models/index_observer.rb:13:in `after_save'

Claudia

--
Claudia Juergen
Universitaetsbibliothek Dortmund
Eldorado
0231/755-4043
https://eldorado.tu-dortmund.de/

[Howard Ding]

Hi Claudia,

That's interesting. I'll take a look at it.

Howard

[Howard Ding]

Hi,

It's pretty easy to fix this in a naive way. It'll take a little bit
longer to make sure that this is actually a good fix.

The main issue in having a good fix is that the way Solr indexing works
currently means that each Work associated with the Group needs to be
reindexed when the Group's attributes change (e.g. the name). I think
that all this can be pushed off to delayed job so that the name change
will look fast to the user. But it may be that there are other factors
(read: callbacks) that slow things down.

Howard

On 12/5/2011 9:33 AM, Claudia J�rgen wrote:

[Howard Ding]

Hi,

I have a patch pushed for this.

Howard

On 12/5/2011 9:33 AM, Claudia J�rgen wrote:

[Claudia Juergen]

Hi Howard,

great, gonna pull it tomorrow and continue with the testing.

Claudia

> --
> You received this message because you are subscribed to the Google Groups
> "bibapp-dev" group.
> To post to this group, send email to bibap...@googlegroups.com.
> To unsubscribe from this group, send email to
> bibapp-dev+...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/bibapp-dev?hl=en.
>
>

Mit freundlichen Gruessen

Claudia Juergen
Universitaetsbibliothek Dortmund
Eldorado
0231/755-4043
https://eldorado.tu-dortmund.de/

Tel.: 0049-231-755-4043

[Howard Ding]

Just as a reminder, since this code is used by delayed_job one has to
restart bibapp (bundle exec rake bibapp:restart) to pick it up. I always
forget to do that.

Howard