Save block broken in authlogic_openid

[Peter Gumeson]

I just pulled down the latest version of authlogic_openid, and the
following line appears to be saving when using a block...

acts_as_authentic.rb (line 75)
return false if new_record? && !openid_complete?

I thought the idea behind saving in a block was to allow you to
conditionally determine if the user has filled in the openid field.
The code above appears to assume that openid is being used, and will
return false even if you are trying to save a normal record that is
not using openid.

Was not sure what this line was trying to address, so I removed it,
and everything worked fine.

However, if there's some reason it needs to be there that I don't know
about... it probably needs to be something like this:
return false if new_record? && using_openid? && !openid_complete?

Peter

[Peter Gumeson]

Sorry, meant to say...

"... the following line appears to be *broken* when *saving* with a
block"

[tfe]

Is there any chance of this being fixed and released in the official
gem? I cannot modify code as above since I don't have control over
gems in my deployment environment (Heroku), but can only reference
ones that are in the gem repositories.

Thanks!

Todd

On Jul 8, 4:31 pm, Peter Gumeson <gume...@gmail.com> wrote:
> Sorry, meant to say...
>
> "... the following line appears to be *broken* when *saving* with ablock"
>
> On Jul 8, 1:27 pm, Peter Gumeson <gume...@gmail.com> wrote:
>
>
>
> > I just pulled down the latest version of authlogic_openid, and the
> > following line appears to be saving when using ablock...
>
> > acts_as_authentic.rb  (line 75)
> > return false if new_record? && !openid_complete?
>

> > I thought the idea behind saving in ablockwas to allow you to