Why we have not added the Request Adapters for Http
Hari K T
Lee
Paul M Jones
On Jan 7, 2012, at 10:51 , Lee wrote:
> Sorry about that, I meant to have this done a few months ago.
Not at all, sir, we've all had a ton to do. Hell, I haven't had time to work on Aura myself until the past few weeks.
> The Stream adapter and tests for the adapters are only major things left to do, though I'm not sure how to properly test the adapters without a server. I havent looked into it yet but maybe the server in PHP 5.4 could be used. Unless someone has a better Idea?
That sounds like a neat idea. I can't think of anything else at this point.
> Does anyone have any thoughts thoughts, ideas or needs with the current implementation? In particular the RequestAdapter design, as I feel it could/should be better.
These are only suggestions after looking at it for about 20 minutes:
- I'm betting that RequestAdapter should become AbstractRequest.
- We have an Aura\Http\Cookies object now; the Request should probably use that instead of an array. You may wish to combine ResponseCookies with Cookies. (We could probably use a Cookie object and a CookieFactory at this point as well.)
- We also have an Aura\Http\Headers object now; the Request should probably use that instead of an array. You may wish to combine ResponseHeaders with Headers. (We could probably use a Header object and a HeaderFactory at this point as well.)
- It may be that we need a ResponseBuilder object to put together Response objects from Request returns.
- It may be that we need to separate the Request object from the way the request is transmitted; e.g. new Request(new CurlTransport, new ResponseBuilder).
- I like the idea of the SplStack of responses. Having said that, I think we need to rename RequestResponse to just Response, and create a ResponseStack object (that is a stack of Response objects).
Incidentally, I've been looking at Buzz and it looks pretty clean:
<https://github.com/kriswallsmith/Buzz>
It may present some ideas for you.
--
Paul M. Jones
http://paul-m-jones.com/
Hari K T
Hari K T
Paul M Jones
On Jan 7, 2012, at 11:51 , Hari K T wrote:
> Buzz is one , there is another one also https://github.com/guzzle/guzzle
Looks kinda heavy: Zend, Monolog, Symfony dependencies. But, can't hurt to look at it.
Hari K T
Hari K T
Not at all, sir, we've all had a ton to do. Hell, I haven't had time to work on Aura myself until the past few weeks.
On Jan 7, 2012, at 10:51 , Lee wrote:
> Sorry about that, I meant to have this done a few months ago.
That sounds like a neat idea. I can't think of anything else at this point.
> The Stream adapter and tests for the adapters are only major things left to do, though I'm not sure how to properly test the adapters without a server. I havent looked into it yet but maybe the server in PHP 5.4 could be used. Unless someone has a better Idea?
These are only suggestions after looking at it for about 20 minutes:
> Does anyone have any thoughts thoughts, ideas or needs with the current implementation? In particular the RequestAdapter design, as I feel it could/should be better.
- I'm betting that RequestAdapter should become AbstractRequest.
Lee
Hari K T
I did looked into the tests . One suggestion is we want to move the test files according to the folder structure or namespace for the src files .
For eg : See the view Helper and the tests .
https://github.com/auraphp/Aura.View/tree/master/tests/Aura/View/Helper
Currently all tests are in a single place , which is hard to track it .
What do you think ?
Hari K T
$response[0]->getContent()
$response->getContent()