Proxy Banner

[Sebastian]

 

The banner response Asterisk Call Manager Proxy 1.22…..

Is not in the format of other packages shouldn’t this ends with 2 CRLF??

Just to make it more standard, and easily to manage.

 

Regards,

 

Sebastian

 

 

[Steve Davies]

2009/3/14 Sebastian <scg...@gmail.com>:

I will check this on Monday. Thanks for pointing it out.

Regards,
Steve

[Sebastian]

Steve,

Have you checked my mails?
What do you think?

Thanks

Se certificó que el correo entrante no contiene virus.
Comprobada por AVG - www.avg.es
Versión: 8.5.278 / Base de datos de virus: 270.11.13/1999 - Fecha de la
versión: 03/13/09 05:59:00

[Steve Davies]

Sorry, had a horrible day at work and no time to check. I am pretty
sure you are right though :)

Steve

2009/3/16 Sebastian <scg...@gmail.com>:

[Sebastian]

Ok, will be in touch, I added your gmail account (jabber) to my contact list
if you want to add me.
I think there are a few things that could improve the proxy a lot.

Thanks, and good look at work :)

Versión: 8.5.278 / Base de datos de virus: 270.11.15/2003 - Fecha de la
versión: 03/15/09 14:07:00

[Steve Davies]

Hi,

I looked at what you meant. The Banner does NOT end in 2 x cr/lf, it
correctly ends in 1 x cr/lf.

This is perfectly normal and is used by many TCP protocols (IMAP, POP,
SMTP, FTP etc etc). The idea is that when you connect to the proxy you
can read exactly one line, and optionally parse that line to confirm
that you have connected to the correct service. In the case of
Astmanproxy, some applications will read the version number off the
end of the string in order to work out which version of Asterisk
Manager they are talking to.

A feature that I intend to add to astmanproxy when I get a couple of
minutes free is a configurable banner that can be set in the config
file - I thought I has some experimental code that did this, but I
appear to have lost it :(.

Regards,
Steve

[Sebastian]

Ok, perfect, have you seen the other mails?, one was regarding that feature
that you talk, so you can know the asterisk manager version. something like
Asterisk Call Manager/1.1 via AstManProxy/1.22, the idea is having the main
banner and just add it the astmanproxy one.
The other problem I'm facing is the one with the differences between the
original manager output and the astmanproxy output, for Actions Command,
when I send them the response has \n instead of \r\n.
On a previous mail I sent the two outputs (astmanproxy and manager) this
should be great to have it the same as manager so we don't have to rewrite
code if we use it for astmanproxy and manager.
I can see on debug that astmanproxy gets ok the Command Action Response but
it seems to eliminate the "blank lines".

If you have any comments regarding this, please let me know.

Regards

Sebastian

-----Original Message-----
From: astma...@googlegroups.com [mailto:astma...@googlegroups.com] On
Behalf Of Steve Davies
Sent: martes, 17 de marzo de 2009 11:16 a.m.
To: astma...@googlegroups.com
Subject: Re: Proxy Banner

Se certificó que el correo entrante no contiene virus.
Comprobada por AVG - www.avg.es

Versión: 8.5.278 / Base de datos de virus: 270.11.16/2006 - Fecha de la
versión: 03/17/09 07:23:00

[Steve Davies]

2009/3/17 Sebastian <scg...@gmail.com>:

>
> Ok, perfect, have you seen the other mails?, one was regarding that feature
> that you talk, so you can know the asterisk manager version. something like
> Asterisk Call Manager/1.1 via AstManProxy/1.22, the idea is having the main
> banner and just add it the astmanproxy one.

I will try to get to that :) Combining the two is a good idea, but it
is harder when there is more than one server.

> The other problem I'm facing is the one with the differences between the
> original manager output and the astmanproxy output, for Actions Command,
> when I send them  the response has \n instead of \r\n.

That should not be the case. Can you provide a trace of a specific
example? I re-checked the code and cannot see how this could ever
happen. All writes go through _write in standard.c, and that puts \r\n
on every line.

> On a previous mail I sent the two outputs (astmanproxy and manager) this
> should be great to have it the same as manager so we don't have to rewrite
> code if we use it for astmanproxy and manager.
> I can see on debug that astmanproxy gets ok the Command Action Response but
> it seems to eliminate the "blank lines".

I remember an email about extra blank lines appearing. I never saw
more information sent though, and the original files were garbled in
the email I received. I assumed the problem was solved when it went
quiet.

Blank lines are not possible in AMP because blank lines are used to
separate request and response blocks. If you have an example which
disagrees with that, please feel free to send that also.

If the attachments are big, put them in a tgz, and send them direct to
me so that we do not clutter the mailing list :)

Regards,
Steve