[KDE] Working around Oxygen in 4.2

[Benjamin Meyer]

So using Arora with Oxygen in KDE 4.2 creates a really bad
experience. I would not be surprised if kde4 users was one of our
largest user base. Although many things were fixed for 4.3 most users
will use KDE 4.2 for many more months. I am thinking of adding a
check that unless you have an environment variable set it will
automatically load plastique over oxygen. Once KDE4.3 is released (or
near to release) we would remove this check. What do you think?

-Benjamin Meyer

[Alexandre Bique]

Can you only use plastique for the webkit's view ?

--
Alexandre Bique

[Benjamin Meyer]

Sure, but why would we? Most people complain about the tab widget,
then then line edit, then QtWebKit. KDE's 4.2's Oxygen makes our app
look ugly.

-Benjamin Meyer

[Alexandre Bique]

On Fri, Mar 27, 2009 at 2:19 PM, Benjamin Meyer <b...@meyerhome.net> wrote:
> Sure, but why would we?  Most people complain about the tab widget, then
> then line edit, then QtWebKit.  KDE's 4.2's Oxygen makes our app look ugly.

I didn't know about this the tabs and the lineedit. Will the fixes be
backported to the next bug fix release of kde ?

--
Alexandre Bique

[Paweł Prażak]

Yes unfortunately, Arora on KDE4 doesn't looks nice.
Three things:
- UI elements (like location bar, search bar, tab icons...) are
rendered wrong
- spacing/margins of UI is broken
- oxygen widgets are rendered bad in webkit

As to the last issue, when I filled the bug report, oxygen guys told
me that it's not oxygen's problem but webkit's. I don't know what
about styling of Qt UI objects with Oxygen, but as one clud expect,
they render perfectly with K* objects. So it could be oxygen's or qt's
fault as well.

IMHO using plastique on KDE4 would only make things worse, but maybe
it's only me ;)

[Benjamin Meyer]

On Mar 27, 2009, at 11:37 AM, Paweł Prażak wrote:

> IMHO using plastique on KDE4 would only make things worse, but maybe
> it's only me ;)

Are you seeing the same issues in plastique?

-Benjamin Meyer

[Paweł Prażak]

No. Plastique works fine except it's plastique ;)

What I meant was, that some widget rendered incorrectly by 2 or 3 pixels is minor issue for me, it still looks better than plastique IMHO.

[Benjamin Meyer]

While the line edit is just a few pixels the tabbar has the text under
the icon which is really annoying and buttons on webpages showing up
as the wrong size which looks really odd. If I was trying out arora
for the first time I would quickly stop because of these obvious
issues (and if they can't fix these obvious issues what else can't
they do?).

-Benjamin Meyer

[Paweł Prażak]

Yes, I know what you mean. What can we do to fix this? Maybe you have a clue where this issue come from (Oxygen or QtWebkit?). Do you think there is a way to do a workaround, just for the time being until we find the cause?

[Benjamin Meyer]

Yes a bunch of the issues have been reported and some of them have
already been fixed and will be in KDE 4.3. One thing we can do is to
sit down and track down where the issues are ourself and submit
patches to KDE and backport the patches to KDE 4.2

-Benjamin Meyer

[Benjamin Meyer]

Ended up being less code then I thought

http://github.com/Arora/arora/commit/34a819786a82ead0bc56794520e7ca97f6663826

[Paweł Prażak]

It was really quick patch, nice :)

You did the right thing with the "Oxygen style has been detected,
loading Plastique style." warning. It's good for the user to know what
happened with their oxygen ;)

On Mar 28, 12:29 am, Benjamin Meyer <b...@meyerhome.net> wrote:
> Ended up being less code then I thought
>

> http://github.com/Arora/arora/commit/34a819786a82ead0bc56794520e7ca97...