contributing angular-seed

18 views
Skip to first unread message

Ilya Fedotov

unread,
May 20, 2011, 10:59:00 AM5/20/11
to angular
Heard about angular at cf.Objective() conference and checking it out.
One suggestion is you should probably link angular-seed from the main
site somewhere. I spent a few hours trying to think how I should
structure an app. JsTD and jasmine are new tools for me also so that
didn't help.

Anyway I discovered angular-seed and have it running. Thanks for
putting it together.
I am kind of new to Git also (use SVN at work) but I cloned external
repo and ... that's about it

I am on windows so I rewrote shell scripts in /scripts to batch files
and wonder if I should contribute those to the repo and if so what is
a right way to go about it.
Should I follow angular instructions from here http://docs.angularjs.org/#!contribute
even though this is different project?

Igor Minar

unread,
May 20, 2011, 11:48:00 AM5/20/11
to ang...@googlegroups.com
Hi Ilya,

The link to angular seed is right here:
http://angularjs.org/#/downloads Is that still hard to find?

You can either send us a pull request as described at
http://docs.angularjs.org/#!contribute

Or you can just email me the windows scripts directly.

I actually have a pending branch with windows scripts for the
angular-seed so I'm curious to see if they could be improved with
something from your version.

thanks,
Igor

> --
> You received this message because you are subscribed to the Google Groups "angular" group.
> To post to this group, send email to ang...@googlegroups.com.
> To unsubscribe from this group, send email to angular+u...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/angular?hl=en.
>
>

Ilya Fedotov

unread,
May 20, 2011, 2:54:38 PM5/20/11
to angular
well that's really easy to find, isn't it?
I guess I went strait for the developer guide, maybe just add a link
under examples to it

I would like to try a pull request if you don't mind so I can learn
more about Git.
and this only 2 new files and no JS was changed so pretty safe

On May 20, 11:48 am, Igor Minar <iimi...@gmail.com> wrote:
> Hi Ilya,
>
> The link to angular seed is right here:http://angularjs.org/#/downloadsIs that still hard to find?
>
> You can either send us a pull request as described athttp://docs.angularjs.org/#!contribute
>
> Or you can just email me the windows scripts directly.
>
> I actually have a pending branch with windows scripts for the
> angular-seed so I'm curious to see if they could be improved with
> something from your version.
>
> thanks,
> Igor
>
> On Fri, May 20, 2011 at 7:59 AM, Ilya Fedotov <ifedo...@gmail.com> wrote:
> > Heard about angular at cf.Objective() conference and checking it out.
> > One suggestion is you should probably link angular-seed from the main
> > site somewhere. I spent a few hours trying to think how I should
> > structure an app. JsTD and jasmine are new tools for me also so that
> > didn't help.
>
> > Anyway I discovered angular-seed and have it running. Thanks for
> > putting it together.
> > I am kind of new to Git also (use SVN at work) but I cloned external
> > repo and ... that's about it
>
> > I am on windows so I rewrote shell scripts in /scripts to batch files
> > and wonder if I should contribute those to the repo and if so what is
> > a right way to go about it.
> > Should I follow angular instructions from herehttp://docs.angularjs.org/#!contribute

Igor Minar

unread,
May 21, 2011, 1:47:26 AM5/21/11
to ang...@googlegroups.com
On Fri, May 20, 2011 at 11:54 AM, Ilya Fedotov <ifed...@gmail.com> wrote:
> well that's really easy to find, isn't it?
> I guess I went strait for the developer guide, maybe just add a link
> under examples to it

which examples are you referring to?

>
> I would like to try a pull request if you don't mind so I can learn
> more about Git.

Not at all!

> and this only 2 new files and no JS was changed so pretty safe

ok

/i

Ilya Fedotov

unread,
May 21, 2011, 4:09:34 PM5/21/11
to angular
I am talking about "cookbook" section as in the http://docs.angularjs.org/#!cookbook
but on home page link says examples


On May 21, 1:47 am, Igor Minar <iimi...@gmail.com> wrote:
> On Fri, May 20, 2011 at 11:54 AM, Ilya Fedotov <ifedo...@gmail.com> wrote:
> > well that's really easy to find, isn't it?
> > I guess I went strait for the developer guide, maybe just add a link
> > under examples to it
>
> which examples are you referring to?
>
>
>
> > I would like to try a pull request if you don't mind so I can learn
> > more about Git.
>
> Not at all!
>
> > and this only 2 new files and no JS was changed so pretty safe
>
> ok
>
> /i
>
>
>
> > On May 20, 11:48 am, Igor Minar <iimi...@gmail.com> wrote:
> >> Hi Ilya,
>
> >> The link to angular seed is right here:http://angularjs.org/#/downloadsIsthat still hard to find?
Reply all
Reply to author
Forward
0 new messages