Remove dependency on DirectX SDK. (issue 7135062)

[apat...@chromium.org]

Reviewers: dgkoch,

Message:
PTAL

Description:
Remove dependency on DirectX SDK.

Please review this at https://codereview.appspot.com/7135062/

Affected files:
M src/build_angle.gypi


Index: src/build_angle.gypi
===================================================================
--- src/build_angle.gypi (revision 1720)
+++ src/build_angle.gypi (working copy)
@@ -217,11 +217,10 @@
'include_dirs': [
'.',
'../include',
- '$(DXSDK_DIR)/include',
],
'sources': [
- 'third_party/murmurhash/MurmurHash3.h'
- 'third_party/murmurhash/MurmurHash3.cpp'
+ 'third_party/murmurhash/MurmurHash3.h',
+ 'third_party/murmurhash/MurmurHash3.cpp',
'common/angleutils.h',
'common/debug.cpp',
'common/debug.h',

[apat...@chromium.org]

Oh and check which branch it's in :)

https://codereview.appspot.com/7135062/

[dan...@transgaming.com]

LGTM (as long as you are aware that the Win8 SDK doesn't work on WinXP)


https://codereview.appspot.com/7135062/diff/2001/src/build_angle.gypi
File src/build_angle.gypi (right):

https://codereview.appspot.com/7135062/diff/2001/src/build_angle.gypi#newcode223
src/build_angle.gypi:223: 'third_party/murmurhash/MurmurHash3.cpp',
whoops! (not surprised there was at least one build issue though -- we
haven't actually tried building with gyp.)

https://codereview.appspot.com/7135062/

[apat...@chromium.org]

This is a gyp change so it should only affect Chrome. We are dynamically
loading the D3DCompiler DLL and will continue to bundle the 43 version
of it in the installer for as long as we support ANGLE on XP. I think
ANGLE built against the Win8 SDK will still work with a dynamically
loaded D3DCompiler_43.dll. It seems to be working for me at least.

https://codereview.appspot.com/7135062/

[dan...@transgaming.com]

On 2013/01/22 22:02:03, apatrick1 wrote:
> This is a gyp change so it should only affect Chrome. We are
dynamically loading
> the D3DCompiler DLL and will continue to bundle the 43 version of it
in the
> installer for as long as we support ANGLE on XP. I think ANGLE built
against the
> Win8 SDK will still work with a dynamically loaded D3DCompiler_43.dll.
It seems
> to be working for me at least.

Right - you're dynamically loading them. That should be fine then.
LGTM.


https://codereview.appspot.com/7135062/