Incorporated patch from haixia@ changing the default implementation of (issue 7194051)

2 views
Skip to first unread message

k...@chromium.org

unread,
Jan 24, 2013, 6:56:19 PM1/24/13
to apat...@chromium.org, angleproj...@googlegroups.com, re...@codereview-hr.appspotmail.com
Reviewers: apatrick1,

Description:
Incorporated patch from haixia@ changing the default implementation of
array index clamping to use the clamp intrinsic. This works more
reliably on pure OpenGL ES devices and on Windows.

Added a mechanism in ShBuiltInResources to choose the strategy for
array index clamping.

BUG=none
TEST=various out-of-bounds array indexing tests and various WebGL
content

Please review this at https://codereview.appspot.com/7194051/

Affected files:
M include/GLSLANG/ShaderLang.h
M src/common/version.h
M src/compiler/Compiler.cpp
M src/compiler/OutputESSL.cpp
M src/compiler/OutputESSL.h
M src/compiler/OutputGLSL.cpp
M src/compiler/OutputGLSL.h
M src/compiler/OutputGLSLBase.cpp
M src/compiler/OutputGLSLBase.h
M src/compiler/ShHandle.h
M src/compiler/ShaderLang.cpp
M src/compiler/TranslatorESSL.cpp
M src/compiler/TranslatorGLSL.cpp
M src/third_party/compiler/ArrayBoundsClamper.cpp
M src/third_party/compiler/ArrayBoundsClamper.h


apat...@chromium.org

unread,
Jan 24, 2013, 6:59:39 PM1/24/13
to k...@chromium.org, angleproj...@googlegroups.com, re...@codereview-hr.appspotmail.com

dan...@transgaming.com

unread,
Jan 25, 2013, 9:13:13 AM1/25/13
to k...@chromium.org, apat...@chromium.org, angleproj...@googlegroups.com, re...@codereview-hr.appspotmail.com
Is a CLA required for this (has that been covered)?

https://codereview.appspot.com/7194051/

k...@chromium.org

unread,
Jan 25, 2013, 1:23:44 PM1/25/13
to apat...@chromium.org, dan...@transgaming.com, angleproj...@googlegroups.com, re...@codereview-hr.appspotmail.com
No, hshi@ is a Google employee. (Got his address wrong in the CL
description, sorry.)


https://codereview.appspot.com/7194051/

dan...@transgaming.com

unread,
Jan 25, 2013, 1:55:35 PM1/25/13
to k...@chromium.org, apat...@chromium.org, angleproj...@googlegroups.com, re...@codereview-hr.appspotmail.com
Ok great. Wasn't sure if he was or not. Thanks!

https://codereview.appspot.com/7194051/
Reply all
Reply to author
Forward
0 new messages