Squeezer 1.0... almost

20 views
Skip to first unread message

Nik Clayton

unread,
Apr 4, 2013, 5:30:49 PM4/4/13
to Kurt Aaholst, Squeezer
Hi Kurt,

cc the list, in the interests of doing this out in the open.

I've just finished (I think) merging all of your changes on the actionbar branch in to mine, and then merged in the caching work that happened on my master branch as well.  I've pushed that up to the repo on github.  So right now my actionbar branch is the closest to the 1.0 release.

I'm keeping the roadmap at https://docs.google.com/document/d/1QvzfP_LvC8uEJwI1TmCYHpvFroopF3YuTLGMWTkD8-s/edit?usp=sharing up to date as things get done and I discover new showstoppers for 1.0.

Fortunately, most of them look reasonably straightforward, and I plan to make a dent in them this weekend.  The most time consuming is probably going to be getting 7" and 10" tablet layouts that work well (and integrating an on-screen volume control).

Let me know if there are any things on that list that you definitely want to tackle (or already have complete but uncommitted) and I'll stay away from them.

When you get the chance can you try merging my actionbar branch in to yours, everything up to https://github.com/nikclayton/android-squeezer/commit/f4c6fee324a0b82c56bec5058f0ef80e39a0af00, and verify that there are no unexpected changes.  The only ones I'm expecting you to see are whitespace changes (I tried to be pretty strict about not letting whitespace only lines sneak through), and some small layout adjustments I've made here and there.

Assuming that merge goes smoothly you should then be able to merge in the head of my actionbar branch with no conflicts.

N
--
http://try-dot-ch.blogspot.com/

Kurt Aaholst

unread,
Apr 6, 2013, 5:50:04 PM4/6/13
to Nik Clayton, Squeezer
Hi Nik,

I have looked through the notes, and I have a few comments.

Filter dialog spinners

These issues can maybe be closed - unless you have found something wrong with it.

Save state (on orientation change AND list -> sub activity -> back)
I can have a look at it - probably not necessary to save state, just use android android standards.

Default action/Action when a list item is selected
No default action should play the item, because this will loose you your current play-list. It is annoying, and we have several comments on the issue list and play store about this issue.
Before we implement this, I will compile a matrix of the current actions and default actions for each  squeezebox item type. Hopefully based on that, we can make an intuitive and uniform solution.

Download support.
Probably not a showstopper, but I really miss the ability to download all tracks from an album/playlist/artist (and perhaps genre). So the sooner we get this, the better.
I think the download manager API is the way to go, but it has to store the music, so the android music player can handle it properly.

Player sync.
This is a squeezebox standard feature. When two or more players are synced they play the same music. This is called grouped by some apps/remotes.
Could be used eg. to provide stereo when you have two radios. I have used it once when we threw a party, using a squeezebox receiver connected to the stereo, and two radios as rear speakers.
I can look at it, but it is not a showstopper for 1.0, so it can be put in the after 1.0 section.

Album art grid view
This is not on the road map now, but I think it should be. Preferably for 1.0, but it can come later if desired.

ActionBar App Icon navigation
I have entered the following comment on the road map.
According to the ActionBar API guide, response to user action on the icon, should be one of two things:
  • Go to the application "home" activity, or
  • Navigate "up" the application's structural hierarchy
Currently we go to the home activity, and this means we should include the FLAG_ACTIVITY_CLEAR_TOP flag. We can change to the up functionality, but then we also need to define the SqueezeBox structural hierarchy.  Eg. "Home -> Playlists -> Playlist -> playlist item" is easy, but what about "Home -> Songs -> Albums of artist of a selected song -> Songs of selected album".


I will merge the your actionbar as soon as possible, and go from there. The only uncommited things I have right now, is in the SqueezerTest project.

Regards
Kurt



2013/4/4 Nik Clayton <n...@ngo.org.uk>
Reply all
Reply to author
Forward
0 new messages