Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
junit classes in live Webkit code
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  2 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
William Ferguson  
View profile  
 More options Oct 9 2012, 5:06 pm
From: William Ferguson <william.fergu...@xandar.com.au>
Date: Tue, 9 Oct 2012 14:06:27 -0700 (PDT)
Local: Tues, Oct 9 2012 5:06 pm
Subject: junit classes in live Webkit code

I just received the following crash report

java.lang.NoClassDefFoundError: junit.framework.Assert
at android.webkit.WebViewCore$WebCoreThread.run(WebViewCore.java:658)
at java.lang.Thread.run(Thread.java:1019)

This is for Gingerbread (2.3.6). Frankly I couldn't believe that a test
class was burnt into and being used by a production class. I wonder whether
they really meant to use the Java "assert" statement instead and hope it
has been fixed since. The Junit Assert class shouldn't be used outside of a
test harness.

Has anyone else seen anything similar?

William


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Chris Sarbora  
View profile  
 More options Oct 12 2012, 4:37 am
From: Chris Sarbora <top...@gmail.com>
Date: Fri, 12 Oct 2012 01:37:56 -0700 (PDT)
Local: Fri, Oct 12 2012 4:37 am
Subject: Re: junit classes in live Webkit code

Hi William,

I just checked and the offending code actually still exists in the AOSP
master branch. If you feel strongly enough about it you may want to bring
it to the attention of the Android Building group, or one more specialized
toward the OS development, not just app development.

Just taking a quick look, that code also locks (via synchronized() block)
on WebViewCore.class, which is probably another no-no.

Chris


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »