Sending DTMF codes from apps

[Gergely Kis]

Hi,

I am opening a new thread to avoid confusions with the old one.

We have been patiently waiting for a generous Google engineer to
review our patches.

For your reference, here they are:
https://android-review.googlesource.com/32820 - changes to frameworks/base
https://android-review.googlesource.com/32821 - changes to packages/apps/Phone
https://android-review.googlesource.com/32810 - changes to development
(adds a sample application)

Highlights:
- Adds precise call state tracking to PhoneStateListener
- Adds an API to the TelephonyManager to send DTMF codes
- Only sends DTMF codes to a call where the other party has a known
caller id. This caller id has to be specified in the request to avoid
sending your phone bank password to someone else because of a race
condition.

Hoping to get some reaction this time ...

Best Regards,
Gergely

--
Kis Gergely
ügyvezető / CEO
MattaKis Consulting
Email: gerge...@mattakis.com
Web: http://www.mattakis.com
Phone: +36 70 408 1723
Fax: +36 27 998 622

[Jean-Baptiste Queru]

I don't have any opinion on what the change is attempting to do or
whether it's reaching that goal - that's not my domain, and I'll let
the domain experts comment. I just had a glance at the change, as it
was easier for me to do that with all the commits lined up.

I have an important note that's relevant for everyone: please don't
change the existing copyright notices.

JBQ

--
Jean-Baptiste M. "JBQ" Queru
Software Engineer, Android Open-Source Project, Google.

Questions sent directly to me that have no reason for being private
will likely get ignored or forwarded to a public forum with no further
warning.

[Gergely Kis]

Oh, and thanks for the review, we will upload with the requested changes.

2012/5/18 Gergely Kis <gerge...@mattakis.com>:
> Well, we did not come up with this idea ourselves:
> https://android-review.googlesource.com/#/c/18746/2/src/com/android/phone/DTMFBroadcastReceiver.java
>
> It was probably a misunderstanding....
>
> Best Regards,
> Gergely
>
> 2012/5/17 Jean-Baptiste Queru <j...@android.com>:

[Gergely Kis]

Well, we did not come up with this idea ourselves:
https://android-review.googlesource.com/#/c/18746/2/src/com/android/phone/DTMFBroadcastReceiver.java

It was probably a misunderstanding....

Best Regards,
Gergely

2012/5/17 Jean-Baptiste Queru <j...@android.com>:

[Jean-Baptiste Queru]

I was talking specifically about existing files.

JBQ