playing with IE7 & IE8

[laurent laffont]

raaaahhhh IE testing

In IE7 & 8 it's not possible to call appendChild on SCRIPT node.

To make this work, I've changed:

TagBrush>>appendChild: anElement

    "In IE7 and IE8 appendChild fails on several node types. So we need to check" 

    < var element=self['@element'];

       if (null == element.canHaveChildren || element.canHaveChildren) {

     element.appendChild(anElement);

       } else {

    element.text = anElement.innerHTML;

      } >

Looks ugly and hacky. Is there a way to handle cross-browser compatibility better ?

Laurent

[Nicolas Petton]

On Wed, 2011-08-31 at 12:10 +0200, laurent laffont wrote:
> raaaahhhh IE testing
>
>
>
>
> In IE7 & 8 it's not possible to call appendChild on SCRIPT node.

I think jQuery should be able to handle that.

What about (untested):

TagBrush >> appendChild: anElement
<jQuery(self['@element']).append(anElement)>

Cheers,
Nico

>
>
> To make this work, I've changed:
>
>
> TagBrush>>appendChild: anElement
> "In IE7 and IE8 appendChild fails on several node types. So we
> need to check"
> < var element=self['@element'];
> if (null == element.canHaveChildren || element.canHaveChildren)
> {
> element.appendChild(anElement);
> } else {
> element.text = anElement.innerHTML;
> } >
>
>
>
>
>
>
> Looks ugly and hacky. Is there a way to handle cross-browser
> compatibility better ?
>
>
> Laurent

--
Nicolas Petton
http://www.nicolas-petton.fr

[laurent laffont]

On Wed, Aug 31, 2011 at 1:29 PM, Nicolas Petton <petton....@gmail.com> wrote:

On Wed, 2011-08-31 at 12:10 +0200, laurent laffont wrote:
> raaaahhhh IE testing
>
>
>
>
> In IE7 & 8 it's not possible to call appendChild on SCRIPT node.

I think jQuery should be able to handle that.

What about (untested):

TagBrush >> appendChild: anElement
   <jQuery(self['@element']).append(anElement)>

Looks like jQuery does not handle this case....

Laurent.

[Nicolas Petton]

then maybe we could change #appendString:

Nico

[laurent laffont]

On Wed, Aug 31, 2011 at 2:51 PM, Nicolas Petton <petton....@gmail.com> wrote:

then maybe we could change #appendString:

Actually cannot find a way that work for all browsers :(

Also note that there's some error in IE7 on jtalk-project.org but I think it's time to drop IE7 compatibility.

Laurent.

[Nicolas Petton]

On Wed, 2011-08-31 at 15:28 +0200, laurent laffont wrote:
> On Wed, Aug 31, 2011 at 2:51 PM, Nicolas Petton
> <petton....@gmail.com> wrote:
> then maybe we could change #appendString:
>
>
>
>
> Actually cannot find a way that work for all browsers :(
>
>
> Also note that there's some error in IE7 on jtalk-project.org but I
> think it's time to drop IE7 compatibility.

Last time I checked, Jtalk (the language) worked on IE7, but the IDE
behaved strangely.

I'll have to run some tests again this week as we're planning to do a
release :)

Cheers,
Nico

[paul]

Hi Nicolas,
we have an javascript error in IE7 and 8. Do you have encountered something like that before? what could be the problem with the split?

SCRIPT5007: no value for attribute "split" Object is Null or undefinied
amber.js, row 111 character 4

Thank you for your help.
Kind regards,
Paul

[Amber Milan Eskridge]

That line in amber.js depends on what you give as arguments to the loadAmber-Function. Can you show the loadAmber-call of your code?

[paul]

Hi Amber,
sure. And thank you already for giving me a hint.

amber.load({ files: ['../../flow/js/Flow-Errors.js', '../../flow/js/Flow-Announcements.js', '../../flow/js/Flow-Models.js', '../../flow/js/Flow-Presenters.js', '../../kando/js/KandoUI-Errors.js', '../../kando/js/KandoUI-Models.js', '../../kando/js/KandoUI-Announcements.js', '../../kando/js/KandoUI-Presenters.js', ],
ready: function (){window.kando = smalltalk.KandoUI._open()}})

Do you think it's the error is just in there or in one of the files?
Kind regards,
Paul

[Göran Krampe]

Hi Amber and folks!

I just have to ask - is your name actually Amber? I get confused every
time. ;)

regards, G�ran

[Amber Milan Eskridge]

I strongly suspect  the error to be in this call, but I do not spot it. 

I came to this page:

http://stackoverflow.com/questions/3966355/ie-wont-split-string-with-javascript

and suspect it could be this error but am not sure. Maybe removing the last comma in the array helps. 

[paul]

Hi Amber,

the error was exactly the trailing comma. Now it's loading but I've got other errors. thank you very much anyways. 

I'm going to try the newest version of amber and maybe this solves the problems.

Kind regards,

Paul