New implementation of Cardstream

[Vincens Mink]

Hi Guys.

I have been working on a new implementation of the cardstream gateway. It replaces the current legacy gatway with the current API from cardstream. Would I create a pull request for a replacement of the current gateway or would I add it as a gateway on its own and call it something like CardstreamDirect/CardstreamModern? The old API is still live and I suspect there will be users who are not interested in switching to the new API as the return and error codes have changed slightly, so it is not just plug and play.

Regards, Vincens

[Nathaniel Talbott]

This should definitely go in as a new gateway vs. replacing the old one. Legacy gateway API's tend to stick around for a loooooooooooooong time.

--
Nathaniel

--
You received this message because you are subscribed to the Google Groups "Active Merchant" group.
To unsubscribe from this group and stop receiving emails from it, send an email to activemerchan...@googlegroups.com.
To post to this group, send email to activem...@googlegroups.com.
Visit this group at http://groups.google.com/group/activemerchant?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

[Vincens Mink]

What is the naming convention on new API gateways with legacy siblings?

[Nathaniel Talbott]

I like to match it up as exactly as possible with how the gateway company differentiates things; typically they have names that they use to keep things straight, and if you can leverage that it makes it easier for ActiveMerchant users to know which gateway class they should be using.

--
Nathaniel

[Vincens Mink]

Thank you.

I have done that now, and proposed a pull. The Travis build failed on all 1.8 versions - should they be supported?

https://travis-ci.org/Shopify/active_merchant/builds/4931013

[Nathaniel Talbott]

Yes, ActiveMerchant is still maintaining backwards compatibility for 1.8.

--
Nathaniel

[Vincens Mink]

Thank you, I will get that fixed

[Vincens Mink]

The build is fixed now and ready to be merged. Please let me know if there is anything else I can do to help with the integration.
https://github.com/Shopify/active_merchant/pull/595