Does include() work with Model.where()?

[evan.leonard]

I'm using Model.where() with an IN clause to load lists of models associated with another list of models. I'm tried using .include on one of my where queries to do part of the work for me, but it didn't seem to work over a polymorphic association (parent_id & parent_type columns in the table). Is this a known issue or should I try to create a test case?

Evan

[ipolevoy]

Looking at code in LazyList, I see no support for include() for polymorphic associations.
It should be possible to add it though, if you feel strongly about it

thanks
igor

[ipolevoy]

Evan, I filed a new issue:
http://code.google.com/p/activejdbc/issues/list?cursor=activejdbc%3A158&ts=1335904895&updated=158
this will be completed soon, I will announce here

thanks
igor

[ipolevoy]

sorry, proper link:
http://code.google.com/p/activejdbc/issues/detail?id=158

[evan.leonard]

I'll do you one better. Attached is a patch with the fix. All tests pass :)

This includes my other patch with the new signature for collect, as this fix requires that one.

Evan

[evan.leonard]

all tests pass on mysql that is...

[ipolevoy]

Man, what a coincidence, I'm working on polymorphic children, almost done!
I will include your patch too, thank you

[Evan Leonard]

Whew. I saw your post and thought "oh no! we probably did the same thing!" Glad we didn't collide :)

Evan

[ipolevoy]

missed each other by a mere inch:)