Running Makefile.dryice.js

[Ed Mackey]

Hi, I downloaded the ACE source and added a new mode I'd like to test.  I'm trying to run "Makefile.dryice.js" using the latest builds of node.js and dryice.  Here's the error I get:

>git submodule update --init --recursive

[...system path...]
Cloning into doc/wiki...
remote: Counting objects: 153, done.
remote: Compressing objects: 100% (149/149), done.
remote: Total 153 (delta 83), reused 4 (delta 2)
Receiving objects: 100% (153/153), 22.70 KiB, done.
Resolving deltas: 100% (83/83), done.

>node Makefile.dryice.js normal

# ace ---------
copy.source.commonjs is deprecated, pass { project:... includes:...} directly as a source
Failed to find module: ../../lib\fixoldbrowsers
Failed to find module: ../../lib\dom
Failed to find module: ../../lib\event
Failed to find module: ../../editor
Failed to find module: ../../edit_session
Failed to find module: ../../undomanager
Failed to find module: ../../virtual_renderer
Failed to find module: ../../theme\textmate
- Source without filename passed to moduleDefines(). Skipping addition of define(...) wrapper.

node.js:201
        throw e; // process.nextTick error, or 'error' event on first tick
              ^
TypeError: Object.keys called on non-object
    at Function.keys (native)
    at cloneProject (C:\Users\Edward\Documents\Git\emackey-ace\Makefile.dryice.js:391:12)
    at buildAce (C:\Users\Edward\Documents\Git\emackey-ace\Makefile.dryice.js:290:30)
    at ace (C:\Users\Edward\Documents\Git\emackey-ace\Makefile.dryice.js:113:5)
    at main (C:\Users\Edward\Documents\Git\emackey-ace\Makefile.dryice.js:74:9)
    at Object.<anonymous> (C:\Users\Edward\Documents\Git\emackey-ace\Makefile.dryice.js:444:5)
    at Module._compile (module.js:432:26)
    at Object..js (module.js:450:10)
    at Module.load (module.js:351:31)
    at Function._load (module.js:310:12)

As you can see the above is from a Windows 7 system, but I also tried building on Linux and got the very same error with Linux-style pathnames in it.

Any idea what went wrong?  Thanks for any advice.

             --Ed.

[Joe Cheng [RStudio]]

I'm getting the same, despite having built successfully in the past (months ago). I'm on Mac OS X 10.7.2. I can go back at least as far as early November and I get similar errors about missing modules and then the Object.keys thing...

Node version v0.6.7

npm version 1.1.0-beta-10

dry...@0.4.1

ugli...@1.2.4

mi...@1.2.4

~/Development/ace(master) $ make

git rev-parse HEAD > .git-ref

mkdir -p build/src

mkdir -p build/demo/kitchen-sink

mkdir -p build/textarea/src

cp -r demo/kitchen-sink/styles.css build/demo/kitchen-sink/styles.css

cp demo/kitchen-sink/logo.png build/demo/kitchen-sink/logo.png

cp -r doc/site/images build/textarea

./Makefile.dryice.js normal

# ace ---------

copy.source.commonjs is deprecated, pass { project:... includes:...} directly as a source

Failed to find module: ../../../../../lib/fixoldbrowsers

Failed to find module: ../../../../../lib/dom

Failed to find module: ../../../../../lib/event

Failed to find module: ../../../../../editor

Failed to find module: ../../../../../edit_session

Failed to find module: ../../../../../undomanager

Failed to find module: ../../../../../virtual_renderer

Failed to find module: ../../../../../theme/textmate

- Source without filename passed to moduleDefines(). Skipping addition of define(...) wrapper.

node.js:201

        throw e; // process.nextTick error, or 'error' event on first tick

              ^

TypeError: Object.keys called on non-object

    at Function.keys (native)

    at cloneProject (/Users/jcheng/Development/ace/Makefile.dryice.js:391:12)

    at buildAce (/Users/jcheng/Development/ace/Makefile.dryice.js:290:30)

    at ace (/Users/jcheng/Development/ace/Makefile.dryice.js:113:5)

    at main (/Users/jcheng/Development/ace/Makefile.dryice.js:74:9)

    at Object.<anonymous> (/Users/jcheng/Development/ace/Makefile.dryice.js:444:5)

    at Module._compile (module.js:432:26)

    at Object..js (module.js:450:10)

    at Module.load (module.js:351:31)

    at Function._load (module.js:310:12)

make: *** [build] Error 1

             --Ed.

--
You received this message because you are subscribed to the Google Groups "Ace Internals Dev" group.
To view this discussion on the web visit https://groups.google.com/d/msg/ace-internals/-/0vmk7HshccYJ.
To post to this group, send email to ace-in...@googlegroups.com.
To unsubscribe from this group, send email to ace-internal...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/ace-internals?hl=en.

[Harutyun Amirjanyan]

i am too getting the same errors when trying to use "Makefile.dryice.js"
but unless you want to create custom build for your project, you don't
need to run it

if your mode works in development environment (i.e. running from
file:// or with static.js)
you are good to send a pull request

[André Luiz Alves Moraes]

I had the same problem, then I made the following change:
diff --git a/Makefile.dryice.js b/Makefile.dryice.js
index cd3dace..c255de9 100755
--- a/Makefile.dryice.js
+++ b/Makefile.dryice.js
@@ -387,6 +387,9 @@ function cloneProject(project) {
         roots: project.roots,
         ignores: project.ignoreRequires
     });
+
+       console.log('Type of: project.currentFiles', typeof project.currentFiles);
+       console.log('Type of: project.ignoredFiles', typeof project.ignoredFiles);

     Object.keys(project.currentFiles).forEach(function(module) {
         clone.currentFiles[module] = project.currentFiles[module];

And then, before the stack trace, i got:

Type of: project.currentFiles undefined
Type of: project.ignoredFiles undefined

By reading the Makefile.dryice.js I don't get any clue on what could be going wrong.

[Joe Cheng [RStudio]]

Bump... it would be SUPER helpful to at least know what versions of Node, npm, dryice are known to work with ace master.

[Joe Walker]

I created a pull request to fix the Ace Makefile which was cloning a commonjs project manually rather than using the clone function. Hopefully this will fix this issue properly.
Joe.

[Joe Cheng [RStudio]]

I can build now--thanks Joe, you just made my day!!

[André Moraes]

I got the same error and is caused by some variable beign undefined.

>> TypeError: Object.keys called on non-object
>>     at Function.keys (native)
>>     at cloneProject
>> (/Users/jcheng/Development/ace/Makefile.dryice.js:391:12)

At this point, the project.currentFiles is undefined and
project.ignoredFiles is also undefined.

Now, the cause for that is a mistery for me.

--
André Moraes
http://andredevchannel.blogspot.com/