Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home
« Groups Home
Request for extension of comment in subWikify function
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  2 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Martin Budden  
View profile  
 More options May 14 2006, 3:55 pm
From: "Martin Budden" <mjbud...@gmail.com>
Date: Sun, 14 May 2006 12:55:35 -0700
Local: Sun, May 14 2006 3:55 pm
Subject: Request for extension of comment in subWikify function
I'm not a fan of overcommenting code, and I think TiddlyWiki has the
balance about right. However there was one instance where I was puzzled
for a little while and an where an extension of the comment would have
helped.

Wikifier.prototype.subWikify = function(output,terminator)
{
        // Temporarily replace the output pointer
        var oldOutput = this.output;
        this.output = output;
...

}

Can you change the comment to:

"Temporarily replace the output pointer, required since subWikify can
be called recursively"

It took me a little while to realise a recursion was involved, since it
is indirect: subWikify can be called from within the
config.formatters.handler function that is called from within
subWikify. Having this little tip would have helped.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Jeremy Ruston  
View profile  
 More options May 15 2006, 5:07 am
From: "Jeremy Ruston" <jeremy.rus...@gmail.com>
Date: Mon, 15 May 2006 10:07:34 +0100
Local: Mon, May 15 2006 5:07 am
Subject: Re: Request for extension of comment in subWikify function
Cool, thanks Martin,

Cheers

Jeremy

On 14/05/06, Martin Budden <mjbud...@gmail.com> wrote:

--
Jeremy Ruston
mailto:jer...@osmosoft.com
http://www.tiddlywiki.com

 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »