Code Review: gwt-google-apis gears Make DatabaseDemo even prettier

[Eric Ayers]

Hello Amit,

Thanks for your observations and improvements of the DatabaseDemo to
use an AUTOINCREMENT key. Could you please review the attached patch
that revises the one you sent me earlier?

This patch updates the DatabaseDemo with the following modifications:

- Uses better SQL coding style
- The Id field now uses an AUTOINCREMENT primary key
- The Id & Timestamp is visible on the UI
- Query results are put in a FlexTable with headings
- Minor formatting changes.

M samples/database/src/com/google/gwt/gears/sample/database/client/DatabaseDemo.java
--
Eric Z. Ayers - GWT Team - Atlanta, GA USA
http://code.google.com/webtoolkit/

[Amit Manjhi]

Hi Eric,

LGTM except aren't you missing "dataTable.clearCell(i, 2);" after these two lines.

+        dataTable.clearCell(i, 0);
+        dataTable.clearCell(i, 1);

You could also clean up the code a bit by introducing a final variable NUM_COLUMNS = 3.

Regards,
Amit

[Eric Ayers]

Hi Amit,

Thanks for the patch and review. I updated the code with your
suggested changes and committed as r880.