Google Web Toolkit Contributors Google Group

Re: one-word review for trivial patch in About.java

gwt.team.fabb...@gmail.com (Freeland Abbott) — Sat, 06 Sep 2008 02:49:08 UT

We test for whether the sentinel is present, but we do two separate
filtration passes (first in dev/core for About.{java,properties}, and the
second in distro-source for the about.{txt,html}). If we had only one file,
the first pass would touch it, and the second would see it as "available,"
might see the contents as up-to-date (e.g. if the source about.{txt,html}

issue 1813 - RootPanel.get(id) fails to set 'position:relative' and 'overflow:hidden'

f...@allen-sauer.com (Fred Sauer) — Sat, 06 Sep 2008 02:34:38 UT

It'll be Halloween again before we know it, I thought I'd ask if there is
any interest in fixing this issue.
1813 RootPanel.get(id) fails to set 'position:relative' and
'overflow:hidden'
[link]
I expect it bites a number of people regularly during GWT development, but

Re: Code Review Request - Issue 2641 - Submenu closes when parent menu is clicked

a...@google.com (Alex Rudnick) — Fri, 05 Sep 2008 23:21:35 UT

LGTM.

Re: one-word review for trivial patch in About.java

sco...@google.com (Scott Blum) — Fri, 05 Sep 2008 23:14:13 UT

I haven't fully reviewed the changes, particularly to /common.ant.xml; but I
am curious why we need two different sentinel files rather than one file
with a composite name?
On Fri, Sep 5, 2008 at 4:41 PM, Freeland Abbott

Re: [gwt-contrib] Re: RR:JS collections

e...@google.com (Emily Crutcher) — Fri, 05 Sep 2008 21:20:24 UT

Cool! Thanks I will use that in my unit test for the next straw man.

Re: Code Review: gwt-google-apis Maps - Convert Point, TileIndex to JS overlays

zun...@google.com (Eric Ayers) — Fri, 05 Sep 2008 20:48:46 UT

Sorry, forgot to attach the actual patch.
2008/9/5 Eric Ayers <zun...@google.com>:

Re: one-word review for trivial patch in About.java

gwt.team.fabb...@gmail.com (Freeland Abbott) — Fri, 05 Sep 2008 20:41:08 UT

No, I didn't test the timing impact, and certainly not over several cycles.
Yeah, I didn't realize it'd have the trickle-down... I thought user was an
independent compile, and didn't think about the samples at all.
Sigh.
Re-done with sentinels restored and expanded for svnrev. Note that the
svnrev value might contain characters illegal in Windows filenames, so

Code Review: gwt-google-apis Maps - Convert Point, TileIndex to JS overlays

zun...@google.com (Eric Ayers) — Fri, 05 Sep 2008 20:40:26 UT

Hello Miguel,
I would like for you to review this patch which converts Point and
TileIndex objects to be sublasses of JavaScriptObject.
M maps/test/com/google/gwt/maps/ client/overlay/MarkerTest.java
M maps/test/com/google/gwt/maps/ client/impl/MinimumMapVersionT est.java
M maps/test/com/google/gwt/maps/ client/MapWidgetEventsTest.jav a

Re: [gwt-contrib] Re: RR : Three new RPC design docs

b...@google.com (BobV) — Fri, 05 Sep 2008 20:34:18 UT

Earlier drafts used to be more complicated. It's difficult to
simplify this without loss of generality.
- The current approach of declaring a sibling _CustomFieldSerializer
type is insufficient because it require a priori knowledge of the
server types which you may be serializing.
- Hardcoding fallback logic into the RPC utility class artificially

Re: Code Review Request - Issue 2301 - Add option to insert a MenuItem at a specific index

j...@google.com (Joel Webber) — Fri, 05 Sep 2008 20:22:09 UT

Change Looks good to me. I love changes that nail a bunch of problems at
once :)
I just realized that it kind of sucks that we're stuck maintaining two
separate lists of items, because of getItems(), but I don't think there's
much we can do about it at this point.

Re: RR:JS collections

mess...@gmail.com (Folke) — Fri, 05 Sep 2008 20:22:15 UT

What about "constructor"? Isn't that one of those properties you
cannot remove completely?

assertNull(newMap.get("constru ctor")); // "function()"
assertFalse(newMap.containsKey ("constructor"));
newMap.put("constructor", "ctor");
assertEquals(1, newMap.size());
assertEquals("ctor", newMap.get("constructor"));

Re: [gwt-contrib] Re: RR : Three new RPC design docs

sco...@google.com (Scott Blum) — Fri, 05 Sep 2008 20:00:56 UT

Okay, but there are very simpler ways to accomplish this?

Re: [gwt-contrib] RR : Three new RPC design docs

sco...@google.com (Scott Blum) — Fri, 05 Sep 2008 20:01:07 UT

I think I get this, although I think the design doc would have been clearer
if the use cases / example code had proceeded the API declarations. I was
really scratching my head about the whole AuthCallback.

Re: [gwt-contrib] Re: RR : Three new RPC design docs

b...@google.com (BobV) — Fri, 05 Sep 2008 19:57:52 UT

All RpcByInterface is describing is a way to map an external type
(i.e. one not controlled by the developer) onto a type for which we
have a concrete implementation in the client code. The implementation
describes how the developer can inject the code that chooses an
alternate representation in the client.

Re: [gwt-contrib] RR : Three new RPC design docs

sco...@google.com (Scott Blum) — Fri, 05 Sep 2008 19:42:27 UT

Maybe I'm dumb, but I really don't get this at all. If you are convinced
that something this complicated is truly necessary, I think you design doc
needs to build a case by strawman-proposing some simpler alternatives and
showing why they are insufficient to solve the problem, progressively
building up to the solution you believe in.