Re: CONTRIBUTORS/CLA-SIGNERS fix

0 views
Skip to first unread message

Scott Blum

unread,
Jan 30, 2007, 1:30:07 PM1/30/07
to Dan Morrill, Google-Web-Tool...@googlegroups.com
Was Essington supposed to be added to the file?

I think I'd rather just svn rename the file and let someone add a
CONTRIBUTORS file later if that's what we decide to do. But I think
we're planning to follow the model used by subversion where it's based
on commit logs, so I'm not sure we're planning to maintain a file.

On 1/30/07, Dan Morrill <morr...@google.com> wrote:
>
> Essington actually noticed that CONTRIBUTORS was out of date.
>
> This patch just moves CONTRIBUTORS -> CLA-SIGNERS and makes CONTRIBUTORS a
> new file awaiting contents when someone gets a patch accepted.
>
> - Dan

Dan Morrill

unread,
Jan 30, 2007, 2:45:51 PM1/30/07
to Scott Blum, Google-Web-Tool...@googlegroups.com

I personally think there's a lot of value in maintaining a CONTRIBUTORS file.  It's quite a bit more visible and easier to peruse for the interested reader than running exotic svn queries.

That said, whether we need one now, I don't have an opinion on.  For now just doing the CLA-SIGNERS rename and updating that file with all the CLAs we have received so far should be enough.


(For those just tuning in:  our intention is to keep people who have signed CLAs on file separate from those who have contributed code, to prevent a hypothetical fame-leech coming along and filing a CLA with us just to get his/her name in the CONTRIBUTORS list for our project. CONTRIBUTORS will be a list of those people from whom we have accepted patches, where CLA-SIGNERS will be a list of those people from whom we may legally accept patches.)

- Dan

Scott Blum

unread,
Jan 30, 2007, 2:49:14 PM1/30/07
to Dan Morrill, Google-Web-Tool...@googlegroups.com
Dan, I didn't see that any new names had been added in your patch.
Can you send me the names that should be added?

Scott Blum

unread,
Feb 18, 2007, 11:34:16 AM2/18/07
to Dan Morrill, Google-Web-Tool...@googlegroups.com
Hi Dan,

What's the status on this? Sandymac is still the only person in the file.

Thanks,
Scott

Rob Jellinghaus

unread,
Apr 12, 2007, 6:22:58 PM4/12/07
to Google Web Toolkit Contributors
Hi folks. Now that 1.4 is entering the home stretch, it seems
appropriate to revive this thread.

By my reading, Dan is pretty clear that there should be a CONTRIBUTORS
file listing those who have contributed code that has landed in GWT.
As of 1.4's release (pending various reviews), there are at least
three outside developers in that category: myself, Sandy MacArthur,
and Jason Essington.

Sandy's patch: http://groups.google.com/group/Google-Web-Toolkit-Contributors/browse_thread/thread/6f1f42eb54c63c44
Jason's patch: http://groups.google.com/group/Google-Web-Toolkit-Contributors/browse_thread/thread/437e631f2fa40379
My patch: http://groups.google.com/group/Google-Web-Toolkit-Contributors/browse_thread/thread/62824fcfb876c8a9

IMHO the file should also include all the Google developers who have
code in the repository, but that's your call. In any case, on behalf
of contributors past, present, and future, I request that someone land
an appropriately populated CONTRIBUTORS file at the root of the
repository before 1.4 ships. (The CLA-SIGNERS file seems fairly
current.)

Thanks for your consideration :-)
Cheers!
Rob

Sandy McArthur

unread,
Apr 12, 2007, 9:33:30 PM4/12/07
to Google-Web-Tool...@googlegroups.com
On 4/12/07, Rob Jellinghaus <rjelli...@gmail.com> wrote:
> As of 1.4's release (pending various reviews), there are at least
> three outside developers in that category: myself, Sandy MacArthur,
> and Jason Essington.

s/MacArthur/McArthur/

--
Sandy McArthur

"He who dares not offend cannot be honest."
- Thomas Paine

Alex Tkachman

unread,
Apr 12, 2007, 10:20:13 PM4/12/07
to Google-Web-Tool...@googlegroups.com
Probably you should count me as well.

Rob Jellinghaus

unread,
Apr 12, 2007, 10:35:50 PM4/12/07
to Google Web Toolkit Contributors
Sorry Sandy and Alex. No slight intended!

Sandy, why does everyone call you "sandymac" in patch notes then?

Cheers!
Rob

Sandy McArthur

unread,
Apr 13, 2007, 12:40:14 AM4/13/07
to Google-Web-Tool...@googlegroups.com
On 4/12/07, Rob Jellinghaus <rjelli...@gmail.com> wrote:
> Sandy, why does everyone call you "sandymac" in patch notes then?

Because "sandymac" is the account name I tend to use because it
pronounces like the first parts of "Sandy McArthur". "sandymc" doesn't
quite roll off the tongue right, I would get things like "Sandy Mic"
or "Sandy Mmka".

Also us Scotts would generally consider a McArthur and MacArthur to be
part of the same clan so they are almost equivalent. It's just some
scotts are more lazy than the other ones.

Joel Webber

unread,
Apr 13, 2007, 9:25:04 AM4/13/07
to Google-Web-Tool...@googlegroups.com
On 4/12/07, Sandy McArthur <sand...@gmail.com> wrote:

On 4/12/07, Rob Jellinghaus <rjelli...@gmail.com> wrote:
> As of 1.4's release (pending various reviews), there are at least
> three outside developers in that category:  myself, Sandy MacArthur,
> and Jason Essington.

s/MacArthur/McArthur/

Yay, a VI user!

:)

John Tamplin

unread,
Apr 13, 2007, 9:36:20 AM4/13/07
to Google-Web-Tool...@googlegroups.com
On 4/13/07, Joel Webber <j...@google.com> wrote:
s/MacArthur/McArthur/

Yay, a VI user!

Actually, that syntax goes back to ed/sed and also exists in perl.

--
John A. Tamplin
Software Engineer, Google

Sandy McArthur

unread,
Apr 13, 2007, 10:29:08 AM4/13/07
to Google-Web-Tool...@googlegroups.com
On 4/13/07, Joel Webber <j...@google.com> wrote:

My first paying programming job required me to log in to the server
and write code in vi. My boss required all code be written in
UPPERCASE even thought the language didn't care about case because he
didn't know how to do case insensitive searches in the unix
enviroment. I didn't hang around long but I learned vi rather well.

Rob Jellinghaus

unread,
Apr 20, 2007, 12:41:25 AM4/20/07
to Google Web Toolkit Contributors
Hm, well, this thread didn't seem to lead to action yet, so just to
make sure it doesn't get dropped:

http://code.google.com/p/google-web-toolkit/issues/detail?id=953

Cheers!
Rob

Reply all
Reply to author
Forward
0 new messages