Core-iSCSI v1.6.2.5 & Core-iSCSI-tools v3.3

[Nicholas A. Bellinger]

Greetings all,

Core-iSCSI v1.6.2.5 and Core-iSCSI-tools v3.3 are now available from:

http://www.kernel.org/pub/linux/kernel/people/nab/iscsi-initiator-core/core-iscsi-v1.6.2.5.tar.bz2
http://www.kernel.org/pub/linux/utils/storage/iscsi/core-iscsi-tools-v3.3.tar.bz2

The changes a relatively minor relating to a fix for core-iscsi on ARM
(namely the Nokia 770), as well as some fixes related to using the
core-iscsi-tools scripts in a busybox environment. v3.3 of the tools
should also fix the authentication problem that appeared with v1.6.2.5
of the stack.

On a related note, the wiki on http://www.linux-iscsi.org has been
filling in nicely, and I would like to thank everyone that has
contributed. linux-iscsi.org will continue to move forward the
evolution of Linux/iSCSI on all platfroms along with the Open/iSCSI and
IET development communities.

Thanks!

--
Nicholas A. Bellinger <n...@kernel.org>

[Nicholas A. Bellinger]

Greetings all,

http://www.kernel.org/pub/linux/kernel/people/nab/iscsi-initiator-core/core-iscsi-v1.6.2.5.tar.bz2
http://www.kernel.org/pub/linux/utils/storage/iscsi/core-iscsi-tools-v3.3.tar.bz2

Thanks!

-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Iscsitarget-devel mailing list
Iscsitar...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/iscsitarget-devel

[Albert Pauw]

Hi Nicholas,

I still have the problem that I can compile this (and the previous)
version on Fedora Core 5, with both kernels 2.6.15.1 and 2.6.16.1
(latest), but when I start it it errors.

dmesg shows:

iscsi_initiator_mod: falsely claims to have parameter iscsi_can_queue

Could it have something to do with having the latest gcc compiler (gcc
version 4.1.0 20060304 (Red Hat 4.1.0-3)).

Thanks,

Albert

[Nicholas A. Bellinger]

Albert,

I believe this is breakage from the usage of the old-style MODULE_PARM()
define in iscsi_initiator_linux_scsi_defs.h

Please check if the following patch using module_param() instead fixes
this.

Thanks!

--
Nicholas A. Bellinger <n...@kernel.org>

Index: iscsi_initiator_linux_scsi_defs.h
===================================================================
--- iscsi_initiator_linux_scsi_defs.h (revision 3175)
+++ iscsi_initiator_linux_scsi_defs.h (working copy)
@@ -153,9 +153,9 @@
#ifdef MODULE
MODULE_DESCRIPTION("PyX iSCSI Initiator Driver Core 1.x Release");
MODULE_LICENSE("GPL");
-MODULE_PARM(iscsi_can_queue, "i");
-MODULE_PARM(iscsi_cmd_per_lun, "i");
-MODULE_PARM(iscsi_sg_tablesize, "i");
+module_param(iscsi_can_queue, int, 0);
+module_param(iscsi_cmd_per_lun, int, 0);
+module_param(iscsi_sg_tablesize, int, 0);
#endif /* MODULE */
module_init(init_iscsi_module);
module_exit(exit_iscsi_module);

[Albert Pauw]

Hi Nicholas,

thanks. This is what I get when I do the compile:

[root@green core-iscsi-v1.6.2.5]# make initiator
KERNEL_DIR=/lib/modules/2.6.16-1.2080_FC5/build/
make -C /lib/modules/2.6.16-1.2080_FC5/build/
SUBDIRS=/usr/src/redhat/BUILD/core-iscsi-v1.6.2.5 modules
make[1]: Entering directory `/usr/src/kernels/2.6.16-1.2080_FC5-i686'
CC [M]
/usr/src/redhat/BUILD/core-iscsi-v1.6.2.5/iscsi_initiator_linux.o
In file included from
/usr/src/redhat/BUILD/core-iscsi-v1.6.2.5/iscsi_initiator_linux.c:55:
/usr/src/redhat/BUILD/core-iscsi-v1.6.2.5/iscsi_initiator_linux_scsi_defs.h:156:36:
error: macro "MODULE_PARM" passed 3 arguments, but takes just 2
In file included from
/usr/src/redhat/BUILD/core-iscsi-v1.6.2.5/iscsi_initiator_linux.c:55:
/usr/src/redhat/BUILD/core-iscsi-v1.6.2.5/iscsi_initiator_linux_scsi_defs.h:156:
warning: data definition has no type or storage class
/usr/src/redhat/BUILD/core-iscsi-v1.6.2.5/iscsi_initiator_linux_scsi_defs.h:156:
warning: type defaults to 'int' in declaration of 'MODULE_PARM'
/usr/src/redhat/BUILD/core-iscsi-v1.6.2.5/iscsi_initiator_linux_scsi_defs.h:157:38:
error: macro "MODULE_PARM" passed 3 arguments, but takes just 2
/usr/src/redhat/BUILD/core-iscsi-v1.6.2.5/iscsi_initiator_linux_scsi_defs.h:157:
warning: data definition has no type or storage class
/usr/src/redhat/BUILD/core-iscsi-v1.6.2.5/iscsi_initiator_linux_scsi_defs.h:157:
warning: type defaults to 'int' in declaration of 'MODULE_PARM'
/usr/src/redhat/BUILD/core-iscsi-v1.6.2.5/iscsi_initiator_linux_scsi_defs.h:158:39:
error: macro "MODULE_PARM" passed 3 arguments, but takes just 2
/usr/src/redhat/BUILD/core-iscsi-v1.6.2.5/iscsi_initiator_linux_scsi_defs.h:158:
warning: data definition has no type or storage class
/usr/src/redhat/BUILD/core-iscsi-v1.6.2.5/iscsi_initiator_linux_scsi_defs.h:158:
warning: type defaults to 'int' in declaration of 'MODULE_PARM'
make[2]: ***
[/usr/src/redhat/BUILD/core-iscsi-v1.6.2.5/iscsi_initiator_linux.o]
Error 1
make[1]: *** [_module_/usr/src/redhat/BUILD/core-iscsi-v1.6.2.5] Error
2
make[1]: Leaving directory `/usr/src/kernels/2.6.16-1.2080_FC5-i686'
make: *** [initiator] Error 2

[Albert Pauw]

Oops,

I had to edit the patch manually, but forgot to put MODULE_PARM in
lowercase.

It seems to work now.

Thanks,

Albert

[Nicholas A. Bellinger]

Albert,

Ok, patch applied for v1.6.2.6. I am going to have a look at the
declarative MaxRecvDataSegmentLength issue mentioned elsewhere and see
if I can come up with a straightforward fix and push this out soon. If
not, I will release v1.6.2.6 with this fix so head off emails from FC5
folks.

Thanks again! :-)

--
Nicholas A. Bellinger <n...@kernel.org>