Re: obexftp - function btkit_unregister_service doesn't return int...

[Erin Yueh]

Hi Jiri,

Thanks for trying obexftp!

On Thu, Sep 3, 2009 at 10:24, Jim Huang<js...@0xlab.org> wrote:
> 2009/9/2, Jiri Tyr <jiri...@gmail.com>:
>>  I have find out a problem in the source codes of the obexftp in your GIT
>>  repository. When I try to compile it, the compiler stops at the
>>  following error:
>>  external/obexftp/obexftp/bt_kit.c:544: error: control reaches end of
>>  non-void function
>>
OK! I will add this line to the source code, since it's not void
function. I am curious about your compiler error, since I don't have
this error.
Below it's my built result:

erin@midnight:~/mydroid/external/obexftp$ . ../../build/envsetup.sh
erin@midnight:~/mydroid/external/obexftp$ cd obexftp/
erin@midnight:~/mydroid/external/obexftp/obexftp$ mm
============================================
PLATFORM_VERSION_CODENAME=Donut
PLATFORM_VERSION=Donut
TARGET_PRODUCT=generic
TARGET_BUILD_VARIANT=eng
TARGET_SIMULATOR=
TARGET_BUILD_TYPE=release
TARGET_ARCH=arm
HOST_ARCH=x86
HOST_OS=linux
HOST_BUILD_TYPE=release
BUILD_ID=Donut
============================================
make: Entering directory `/home/erin/mydroid'
target thumb C: libobexftp <=
/home/erin/mydroid/external/obexftp/obexftp/object.c
target thumb C: libobexftp <=
/home/erin/mydroid/external/obexftp/obexftp/client.c
/home/erin/mydroid/external/obexftp/obexftp/client.c: In function 'client_done':
/home/erin/mydroid/external/obexftp/obexftp/client.c:306: warning:
pointer targets in passing argument 2 of 'cli->infocb' differ in
signedness
/home/erin/mydroid/external/obexftp/obexftp/client.c: In function
'obexftp_connect_service':
/home/erin/mydroid/external/obexftp/obexftp/client.c:572: warning:
assignment discards qualifiers from pointer target type
/home/erin/mydroid/external/obexftp/obexftp/client.c:576: warning:
assignment discards qualifiers from pointer target type
/home/erin/mydroid/external/obexftp/obexftp/client.c: In function
'obexftp_put_data':
/home/erin/mydroid/external/obexftp/obexftp/client.c:1174: warning:
pointer targets in assignment differ in signedness
target thumb C: libobexftp <=
/home/erin/mydroid/external/obexftp/obexftp/obexftp_io.c
/home/erin/mydroid/external/obexftp/obexftp/obexftp_io.c: In function
'get_fileinfo':
/home/erin/mydroid/external/obexftp/obexftp/obexftp_io.c:55: warning:
pointer targets in passing argument 1 of 'gmtime' differ in signedness
target thumb C: libobexftp <=
/home/erin/mydroid/external/obexftp/obexftp/cache.c
/home/erin/mydroid/external/obexftp/obexftp/cache.c: In function
'obexftp_cache_list':
/home/erin/mydroid/external/obexftp/obexftp/cache.c:214: warning:
pointer targets in passing argument 1 of 'strdup' differ in signedness
/home/erin/mydroid/external/obexftp/obexftp/cache.c: In function
'parse_directory':
/home/erin/mydroid/external/obexftp/obexftp/cache.c:265: warning:
pointer targets in passing argument 1 of 'Utf8ToChar' differ in
signedness
/home/erin/mydroid/external/obexftp/obexftp/cache.c:265: warning:
pointer targets in passing argument 2 of 'Utf8ToChar' differ in
signedness
target thumb C: libobexftp <=
/home/erin/mydroid/external/obexftp/obexftp/unicode.c
/home/erin/mydroid/external/obexftp/obexftp/unicode.c: In function
'CharToUnicode':
/home/erin/mydroid/external/obexftp/obexftp/unicode.c:134: warning:
implicit declaration of function 'OBEX_CharToUnicode'
/home/erin/mydroid/external/obexftp/obexftp/unicode.c: In function
'UnicodeToChar':
/home/erin/mydroid/external/obexftp/obexftp/unicode.c:196: warning:
implicit declaration of function 'OBEX_UnicodeToChar'
/home/erin/mydroid/external/obexftp/obexftp/unicode.c: In function 'Utf8ToChar':
/home/erin/mydroid/external/obexftp/obexftp/unicode.c:255: warning:
pointer targets in passing argument 1 of 'strlen' differ in signedness
/home/erin/mydroid/external/obexftp/obexftp/unicode.c:256: warning:
pointer targets in passing argument 1 of 'strncpy' differ in
signedness
/home/erin/mydroid/external/obexftp/obexftp/unicode.c:256: warning:
pointer targets in passing argument 2 of 'strncpy' differ in
signedness
target thumb C: libobexftp <=
/home/erin/mydroid/external/obexftp/obexftp/bt_kit.c
/home/erin/mydroid/external/obexftp/obexftp/bt_kit.c: In function
'btkit_unregister_service':
/home/erin/mydroid/external/obexftp/obexftp/bt_kit.c:544: warning:
control reaches end of non-void function
target StaticLib: libobexftp
(out/target/product/generic/obj/STATIC_LIBRARIES/libobexftp_intermediates/libobexftp.a)
make: Leaving directory `/home/erin/mydroid'

Regards,
Erin Yueh
http://0xlab.org

[Jim Huang]

2009/9/3 Erin Yueh <erin...@gmail.com>:

> Hi Jiri,
> Thanks for trying obexftp!
>

[...]

> OK! I will add this line to the source code, since it's not void
> function. I am curious about your compiler error, since I don't have
> this error.
> Below it's my built result:
>

[...]

It looks that recent gcc has restrict rules for syntax.
Erin fixed that:
http://gitorious.org/android-obex/obexftp/commit/82f539dfe2611e9f5faef233222038f285292cd2

We would suggest Jiri to continue discussing on 0xlab-devel
mailing-list for such problems.

Thanks,
Jim Huang (jserv)
http://0xlab.org/