HTMLTable.Sort

[Robert]

String sorting in htmltable is not prepared for localization.
Recently I had to do it and there was two options:
- convert localized string to ascii sortable string
- change the HTMLTable.Sort source (refactor) to allow including of
different sorting functions.

I followed first path (http://jsfiddle.net/6a3Kq/) but I still believe
the second one is better.
It would only need small change in source:
var sorter = parser.sorter;
if (!sorter){

var data = this.parseData(parser).sort(function(a, b){
if (a.value === b.value) return 0;
return a.value > b.value ? 1 : -1;
});

[Robert]

String sorting in htmltable is not prepared for localization.
Recently I had to do it and there was two options:
- convert localized string to ascii sortable string
- change the HTMLTable.Sort source (refactor) to allow including of
different sorting functions.

I followed first path (http://jsfiddle.net/6a3Kq/) but I still believe
the second one is better.

It would only need small change in source (here:
https://github.com/mootools/mootools-more/blob/master/Source/Interface/HtmlTable.Sort.js#L219):

var sorter = parser.sorter;
if (!sorter){

sorter = function(a, b){

if (a.value === b.value) return 0;
return a.value > b.value ? 1 : -1;
}
}

var data = this.parseData(parser).sort(sorter);

What do You think?

[Aaron Newton]

Please post a bug in lighthouse for this; the forums is a poor place for us to try and keep up with issues.

[Robert]

I didn,t see it as a bug, I just wanted to discuss it :-)

[Aaron Newton]

That's fine, but if you think you've found something wrong, you should open a ticket anyway. It's how we know what is and isn't working.

[Robert]

I will try to send You a pull request, only need to lern git and get
an account on github ;-)

[Aaron Newton]

Learning opportunities are awesome!

[Robert]

Just did. ;)

[Aaron Newton]

I'm not sure how this solves the issue, or even what the issue,
specifically is. This is part of why I've suggested that you open a
ticket. We don't deal with issues here on the mailing list. A pull
request is awesome, we love that stuff, but it's not clear, on its
own, what this is trying to fix. There's no example of what's not
working and how this change makes it work better.

Step 1: open a ticket and describe the issue, ideally including a
jsfiddle that demonstrates the shortcoming.
Step 2: identify the problem and suggest a change (optional)
Step 3: send a pull request with a change that references the ticket
(optional)

Here you've skipped to step 3. It's really awesome that you want to
help out, but you NEED to start with Step 1 - it's the one thing that
ISN'T optional.

That said, what I THINK you're suggesting is that parsers need to have
optional sorting functions in addition to matches. I don't disagree
with this, but it's not clear how pulling your suggested change will
solve things for the existing parsers. Do we need to alter all the
included parsers, too? Stuff like this matters, and it's the stuff
we'd discuss IN THE TICKET. So, please, go back to step one and then
work from there.

-aaron

On Jun 7, 1:49 am, Robert <forpoc...@gmail.com> wrote:
> String sorting in htmltable is not prepared for localization.
> Recently I had to do it and there was two options:
> - convert localized string to ascii sortable string
> - change the HTMLTable.Sort source (refactor) to allow including of
> different sorting functions.
>
> I followed first path (http://jsfiddle.net/6a3Kq/) but I still believe
> the second one is better.

> It would only need small change in source (here:https://github.com/mootools/mootools-more/blob/master/Source/Interfac...

[Robert]

Pull requests are visible on the "issues" page - but anyway, I added
an issue with sample and explanation.