Message from discussion
help me identify perf regressions
Received: by 10.204.148.22 with SMTP id n22mr7985400bkv.0.1351645265130;
Tue, 30 Oct 2012 18:01:05 -0700 (PDT)
X-BeenThere: webkit-garden...@chromium.org
Received: by 10.204.147.6 with SMTP id j6ls1366420bkv.9.gmail; Tue, 30 Oct
2012 18:01:04 -0700 (PDT)
Received: by 10.204.5.151 with SMTP id 23mr11017654bkv.3.1351645263793;
Tue, 30 Oct 2012 18:01:03 -0700 (PDT)
Received: by 10.204.5.151 with SMTP id 23mr11017651bkv.3.1351645263740;
Tue, 30 Oct 2012 18:01:03 -0700 (PDT)
Return-Path: <sulli...@google.com>
Received: from mail-bk0-f52.google.com (mail-bk0-f52.google.com [209.85.214.52])
by mx.google.com with ESMTPS id fy18si3064938bkc.137.2012.10.30.18.01.03
(version=TLSv1/SSLv3 cipher=OTHER);
Tue, 30 Oct 2012 18:01:03 -0700 (PDT)
Received-SPF: pass (google.com: domain of sulli...@google.com designates 209.85.214.52 as permitted sender) client-ip=209.85.214.52;
Authentication-Results: mx.google.com; spf=pass (google.com: domain of sulli...@google.com designates 209.85.214.52 as permitted sender) smtp.mail=sulli...@google.com; dkim=pass header...@google.com
Received: by mail-bk0-f52.google.com with SMTP id j10so358839bkw.25
for <webkit-garden...@chromium.org>; Tue, 30 Oct 2012 18:01:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=google.com; s=20120113;
h=mime-version:in-reply-to:references:date:message-id:subject:from:to
:cc:content-type:x-system-of-record;
bh=ehVXMKiST8o2+YqsFyMv0+w9KLKL0l4EaFzkDmpGWP4=;
b=IX8iUhSfQeN4fzdCADI3pvDf1WK6KrYxUfTo9nYp9znQt1KKMDDlworOnJ8OxbLcNk
cwzcrE2z42zngJtdP5h+A78mmheuBkTQFUcByJNBzWuTbcjDIRQfmGhfDyVi07Y3s5br
12Prg0WFuvorJTuwwQm5wFuno+8w7TCDLk9qJR0zp7MVzQVcMNL7SSl97RUbRhxr7Cy1
SkJVtxCOLeEozINypycudLJ6A6JGngt56S8hkkHe2m62MOAYi0MyBw0DpxA/cJLehO2a
u2r83XbqhURTYEr51BXHCIRdUSpfyAdEAeqaUAen9MnJM6kRVOoVmd60hfNRI7xHG+xF
eCbA==
d=google.com; s=20120113;
h=mime-version:in-reply-to:references:date:message-id:subject:from:to
:cc:content-type:x-system-of-record:x-gm-message-state;
bh=ehVXMKiST8o2+YqsFyMv0+w9KLKL0l4EaFzkDmpGWP4=;
b=KUkSQmCHl21qxTDsciMEcYUpSROKPwynJnAZAEHfLkO2PaPlkj1r+W6R4CAu+WxXQR
mbaixrsaKWa90vvH8KQeYMz52tiuqhPsueFAoJzyY0L0ygxDY81FsR48uSwYNehVR/0r
/PXRqdi9rnc8lpgoG70R/y+HgKUA7miV5/1J7s1rZ0VjkY8KdzDIW/gL1rXphyqsZFYI
Hbq1cPEZmEoqgeYI3DcvY14bRAQpWcEHV0FZpASpLi2pT8jqn0KlPJABjLNjt6PlNfuA
28I9QjAMRKA0fowlMThznaMPaSMiuui6ByEKMpqlm8IMDp7/aqzy4TK4XmL9y4SnhDk9
8+Rw==
MIME-Version: 1.0
Received: by 10.204.147.5 with SMTP id j5mr11057037bkv.21.1351645263456; Tue,
30 Oct 2012 18:01:03 -0700 (PDT)
Received: by 10.204.225.143 with HTTP; Tue, 30 Oct 2012 18:01:03 -0700 (PDT)
In-Reply-To: <CAEoffTAr0tCBy=4ftPue3V_eJL+0c2aQYgN244=3LLW574H...@mail.gmail.com>
References: <CANMdWTt76D0Czxo4Gp_kur-AYUW+iiYDtk3yXjvkYMR2yj4...@mail.gmail.com>
<CAEoffTAr0tCBy=4ftPue3V_eJL+0c2aQYgN244=3LLW574H...@mail.gmail.com>
Date: Tue, 30 Oct 2012 21:01:03 -0400
Message-ID: <CAJB_qsm+YYY=hquLpM139gh4GTaXOF6LUTOsjbgi8Tgpv5E...@mail.gmail.com>
Subject: Re: help me identify perf regressions
From: Annie Sullivan <sulli...@google.com>
To: Dirk Pranke <dpra...@chromium.org>
Cc: Ojan Vafai <o...@chromium.org>, webkit-gardening <webkit-garden...@chromium.org>
Content-Type: multipart/alternative; boundary=0015174bde04ca693d04cd506fef
X-System-Of-Record: true
X-Gm-Message-State: ALoCoQmpx0F2oODtLWlS5OYHxYtFzJc2e2ThuMWA7qH3c0kpiGA98/qY+Kbz9q0Wuh4IgZDXQnBJCKId+TaBnFNmQN2DPrwI2bcDeDa9YrypX+cGnHyHwDWccCm4DIE0904KonujSv+9D49NAUsVHIJgV22IvRNSoSvk+QYmG+CuVfdVZkDFYIN0ICiSqtYHntz/AAi24Y/VjcPeVAO3Z1EKwiZ4RTIp5A==
--0015174bde04ca693d04cd506fef
Content-Type: text/plain; charset=ISO-8859-1
FYI, I think we can probably manage to reduce the false positives if we get
some feedback on why they're not helpful. Some things that could possibly
be problems:
* Monitoring too many graphs
* Alerts too sensitive
* Getting emails on improvements as well as regressions
* % change calculation incorrect
* Actual problems with GASP
Any Googler who wants to take a look at the alerts can see a full archive
at
https://groups.google.com/a/google.com/forum/?fromgroups#!forum/webkit-gasper
If anybody has time to make a list of good/bad alerts, it would be helpful
to have the "Debug this alert in Gasper" link, the rev the reported
regression happens at, and a quick explanation of why it's not helpful. You
don't need to look at all the alerts; a small sample would be useful. I
made a doc here for feedback: http://go/webkit-gasper-feedback
Thanks!
-Annie
On Tue, Oct 30, 2012 at 6:46 PM, Dirk Pranke <dpra...@chromium.org> wrote:
> This sounds great!
>
> -- Dirk
>
> On Tue, Oct 30, 2012 at 3:04 PM, Ojan Vafai <o...@chromium.org> wrote:
> > I'm testing out gasper alerts for the webkit canary bots. So far today
> it's
> > been ~40 false positives + 1 true regression (that got rolled back).
> That's
> > actually a good enough hit rate that I think it's much easier than
> manually
> > monitoring the perf graphs.
> >
> > That said, I have 0 insight into whether it's missing any actual
> > regressions. Over the next few weeks, could the active gardeners just
> > ping/cc me anytime they encounter a perf regression?
> >
> > If there are no missing regressions, then I think we could make it the
> > gardeners job to monitor the gasper emails instead of having to look at
> the
> > graphs. It would be considerably less work and would catch perf
> regressions
> > much faster.
> >
> > Thanks,
> > Ojan
> >
> > --
> >
> >
>
--0015174bde04ca693d04cd506fef
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
<div>FYI, I think we can probably manage to reduce the false positives if w=
e get some feedback on why they're not helpful. Some things that could =
possibly be problems:<br></div><div><br></div><div>* Monitoring too many gr=
aphs</div>
<div>* Alerts too sensitive</div><div>* Getting emails on improvements as w=
ell as regressions</div><div>* % change calculation incorrect</div><div>* A=
ctual problems with GASP</div><div><br></div><div>Any Googler who wants to =
take a look at the alerts can see a full archive at=A0<a href=3D"https://gr=
oups.google.com/a/google.com/forum/?fromgroups#!forum/webkit-gasper">https:=
//groups.google.com/a/google.com/forum/?fromgroups#!forum/webkit-gasper</a>=
</div>
<div><br></div><div>If anybody has time to make a list of good/bad alerts, =
it would be helpful to have the "Debug this alert in Gasper" link=
, the rev the reported regression happens at, and a quick explanation of wh=
y it's not helpful. You don't need to look at all the alerts; a sma=
ll sample would be useful. I made a doc here for feedback: <a href=3D"http:=
//go/webkit-gasper-feedback">http://go/webkit-gasper-feedback</a></div>
<div class=3D"gmail_extra"><br></div><div class=3D"gmail_extra">Thanks!</di=
v><div class=3D"gmail_extra">-Annie</div><div class=3D"gmail_extra"><br><di=
v class=3D"gmail_quote">On Tue, Oct 30, 2012 at 6:46 PM, Dirk Pranke <span =
dir=3D"ltr"><<a href=3D"mailto:dpra...@chromium.org" target=3D"_blank">d=
pra...@chromium.org</a>></span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">This sounds great!<br>
<span class=3D"HOEnZb"><font color=3D"#888888"><br>
-- Dirk<br>
</font></span><div><div class=3D"h5"><br>
On Tue, Oct 30, 2012 at 3:04 PM, Ojan Vafai <<a href=3D"mailto:ojan@chro=
mium.org">o...@chromium.org</a>> wrote:<br>
> I'm testing out gasper alerts for the webkit canary bots. So far t=
oday it's<br>
> been ~40 false positives + 1 true regression (that got rolled back). T=
hat's<br>
> actually a good enough hit rate that I think it's much easier than=
manually<br>
> monitoring the perf graphs.<br>
><br>
> That said, I have 0 insight into whether it's missing any actual<b=
r>
> regressions. Over the next few weeks, could the active gardeners just<=
br>
> ping/cc me anytime they encounter a perf regression?<br>
><br>
> If there are no missing regressions, then I think we could make it the=
<br>
> gardeners job to monitor the gasper emails instead of having to look a=
t the<br>
> graphs. It would be considerably less work and would catch perf regres=
sions<br>
> much faster.<br>
><br>
> Thanks,<br>
> Ojan<br>
><br>
</div></div>> --<br>
><br>
><br>
</blockquote></div><br></div>
--0015174bde04ca693d04cd506fef--