clang buildbot failure in Chromium FYI on Chromium Linux Debug Clang
cl...@chromium.org
Full details are available at:
http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Linux%20Debug%20Clang/builds/3462
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 68932
Blamelist: sat...@chromium.org
BUILD FAILED: failed compile
sincerely,
-The Buildbot
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 68933
Blamelist: phajd...@chromium.org
Nico Weber
you broke the clang build:
make -k -j4 -r base_unittests chrome BUILDTYPE=Debug
ACTION Extracting last change to
/mnt/data/build/slave/Chromium_Linux_Debug_Clang/build/src/out/Debug/obj/gen/build/LASTCHANGE
out/Debug/obj/gen/build/LASTCHANGE.always
CXX(target) out/Debug/obj.target/base_i18n/base/i18n/file_util_icu.o
CXX(target) out/Debug/obj.target/base_i18n/base/i18n/number_formatting.o
CXX(target) out/Debug/obj.target/app_base/app/active_window_watcher_x.o
CXX(target) out/Debug/obj.target/worker/chrome/worker/webworkerclient_proxy.o
In file included from base/i18n/file_util_icu.cc:12:
./base/singleton.h:200:35: error: no class named 'FriendType' in
'FriendMaker<<anonymous>::IllegalCharacters>'
friend class FriendMaker<Type>::FriendType;
^
base/i18n/file_util_icu.cc:25:12: note: in instantiation of template
class 'Singleton<<anonymous>::IllegalCharacters,
DefaultSingletonTraits<<anonymous>::IllegalCharacters>,
<anonymous>::IllegalCharacters>' requested here
return Singleton<IllegalCharacters>::get();
^
base/i18n/file_util_icu.cc:25:42: error: 'get' is a private member of
'Singleton<<anonymous>::IllegalCharacters,
DefaultSingletonTraits<<anonymous>::IllegalCharacters>,
<anonymous>::IllegalCharacters>'
return Singleton<IllegalCharacters>::get();
^
In file included from base/i18n/file_util_icu.cc:12:
./base/singleton.h:207:16: note: declared private here
static Type* get() {
^
./base/singleton.h:200:35: error: no class named 'FriendType' in
'FriendMaker<<anonymous>::LocaleAwareComparator>'
friend class FriendMaker<Type>::FriendType;
^
base/i18n/file_util_icu.cc:84:12: note: in instantiation of template
class 'Singleton<<anonymous>::LocaleAwareComparator,
DefaultSingletonTraits<<anonymous>::LocaleAwareComparator>,
<anonymous>::LocaleAwareComparator>' requested here
return Singleton<LocaleAwareComparator>::get();
^
base/i18n/file_util_icu.cc:84:46: error: 'get' is a private member of
'Singleton<<anonymous>::LocaleAwareComparator,
DefaultSingletonTraits<<anonymous>::LocaleAwareComparator>,
<anonymous>::LocaleAwareComparator>'
return Singleton<LocaleAwareComparator>::get();
^
In file included from base/i18n/file_util_icu.cc:12:
./base/singleton.h:207:16: note: declared private here
static Type* get() {
^
4 errors generated.
Chances are that your code is not valid C++, clang tends to be more
strict than gcc and msvc (but it might be that this is a clang bug). I
didn't look closely, but this might be covered by
http://clang.llvm.org/compatibility.html#dep_lookup
Can you take a look?
Thanks,
Nico
Nico Weber
Satish Sampath
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 68935
Blamelist: tfa...@chromium.org
Evan Martin
From a glance at
./base/singleton.h:200:35: error: no class named 'FriendType' in
'FriendMaker<<anonymous>::IllegalCharacters>'
friend class FriendMaker<Type>::FriendType;
^
I wonder if "class" the wrong word here. Maybe you mean "typename"?
(Random guess, I don't really understand where typename ought to be
used.)
Satish Sampath
Nico Weber
> Generally, clang obeys C++ specs better than other compilers.
> From a glance at
> ./base/singleton.h:200:35: error: no class named 'FriendType' in
> 'FriendMaker<<anonymous>::IllegalCharacters>'
> friend class FriendMaker<Type>::FriendType;
> ^
>
> I wonder if "class" the wrong word here. Maybe you mean "typename"?
> (Random guess, I don't really understand where typename ought to be
> used.)
typename means "all types, i.e. classes but also pointers, primitive
types, etc.". Clang doesn't like it either:
test.cc:31:3: warning: non-class type 'typename
FriendMaker<T>::FriendType' cannot be a friend
friend typename FriendMaker<T>::FriendType;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
Since the intent of http://codereview.chromium.org/5682008 is to
"enforce that the Singleton<T> pattern can only be used within classes
which want singleton-ness", I wonder if a better design would be to
make the get method protected and have the classes that want
singleton-ness derive from Singleton<ConcreteClass>?
Satish Sampath
Nico Weber
> Wouldn't using the Singleton<T> in a header mean that the methods/code get
> included in each compilation unit?
Ah, right.
Nico Weber
> On Sat, Dec 11, 2010 at 2:01 PM, Satish Sampath <sat...@chromium.org> wrote:
>> Wouldn't using the Singleton<T> in a header mean that the methods/code get
>> included in each compilation unit?
>
> Ah, right.
I'm not sure if there's a standards-compliant way to make T a friend
of Singleton. The obvious way is forbidden by [dcl.type.elab]p2 (
http://www.kuzbass.ru:8086/docs/isocpp/dcl.html#dcl.type.elab ):
template<class T>
class Singleton {
friend class T; // not allowed
};
(The reason for this is probably that it's not clear if this declares
a new class T that's friend, of if T is required to have class type
and should be a friend?)
Your hack in the version that's accepted by MSVC is explicitly
forbidden by the footnote in [class.friend]p2 (
http://www.kuzbass.ru:8086/docs/isocpp/access.html#class.friend ) "The
class-key of the elaborated-type-specifier is required" – class-key is
one of class, struct, or union, so you can't say "friend typename".
Since Comeau, clang, and MSVC all reject the gcc version of your hack
I think it's not valid C++ either (one possible explanation might be
in [dcl.type.elab]p2 too: typedefs can't be friends either. This is a
bit hand-wavy though).
But! This is probably enough for Singleton, and it compiles at least
with gcc, clang, and Comeau:
template<class T>
class Singleton {
friend T* T::GetInstance();
};
This forces the GetInstance() method to be called "GetInstance()", but
that might be ok – maybe even a good thing. I believe that this
fulfills all the design constraints:
* Client code shouldn't be allowed to say Singleton<SomeClass>::get()
* SomeClass's header should be able to forward-declare Singleton
* Code should be valid C++
I only tried this with a reduced test case – maybe you can try this in
your real CL when you reland it?
Satish Sampath
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69050
Blamelist: j...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69053
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69107
Blamelist: sat...@chromium.org
Nico Weber
Not sure if this is your fault or clang's, will take a look tomorrow.
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69108
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69109
Blamelist: timu...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69110
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69112
Blamelist: fin...@chromium.org,ha...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69113
Blamelist: ach...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69115
Blamelist: chrome-...@google.com
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69117
Blamelist: tfa...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69118
Blamelist: dil...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69121
Blamelist: ri...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69123
Blamelist: altim...@chromium.org,jo...@chromium.org
Hans Wennborg
> satish: FYI
>
> Not sure if this is your fault or clang's, will take a look tomorrow.
Here's a reduction...
#include <cstdio>
// From base/singleton.h
template <typename Type>
class Singleton {
private:
friend Type* Type::GetInstance();
static Type* get() {
return 0; // More magic here in reality...
}
};
// From chrome/browser/about_flags.cc
namespace {
class FlagState {
public:
static FlagState* GetInstance() {
return Singleton<FlagState>::get();
}
};
} // namespace
void f() {
FlagState* f = FlagState::GetInstance();
std::printf("%p\n", f);
}
// A main() so we can try to link it.
int main() {
f();
}
clang++ /tmp/a.cc
/usr/bin/ld: /tmp/cc-1QAUEc.o: in function f():/tmp/a.cc(.text+0x9):
error: undefined reference to '(anonymous
namespace)::FlagState::GetInstance()'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Hans Wennborg
Satish asked whether defining FlagState::GetInstance() out-of-line
helps, and indeed it does; the error goes away.
This definitely feels like a Clang bug. I'll try to reduce it a bit
more and file a bug.
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69124
Blamelist: nkos...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69125
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69126
Blamelist: da...@chromium.org
Hans Wennborg
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69128
Blamelist: jo...@chromium.org,ri...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69129
Blamelist: sat...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69130
Blamelist: dmaz...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69131
Blamelist: a...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69132
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69133
Blamelist: bry...@google.com
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69135
Blamelist: sad...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69136
Blamelist: bry...@google.com
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69137
Blamelist: jkno...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69138
Blamelist: dmac...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69141
Blamelist: to...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69142
Blamelist: bry...@google.com
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69145
Blamelist: ha...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69146
Blamelist: da...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69147
Blamelist: ev...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69150
Blamelist: cben...@chromium.org,da...@chromium.org,dhol...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69151
Blamelist: kka...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69152
Blamelist: jkno...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69155
Blamelist: cs...@chromium.org,kka...@chromium.org,xiy...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69156
Blamelist: jkno...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69157
Blamelist: pfel...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69158
Blamelist: dhol...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69161
Blamelist: jhaw...@google.com
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69163
Blamelist: dhol...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69164
Blamelist: a...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69165
Blamelist: robert...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69167
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69169
Blamelist: ev...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69172
Blamelist: mo...@chromium.org,nirn...@chromium.org,nsyl...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69174
Blamelist: al...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69175
Blamelist: erikw...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69178
Blamelist: da...@chromium.org,mbe...@chromium.org,robert...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69180
Blamelist: a...@chromium.org,vital...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69183
Blamelist: will...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69184
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69187
Blamelist: dmic...@google.com
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69189
Blamelist: al...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69190
Blamelist: will...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69191
Blamelist: dmic...@google.com
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69193
Blamelist: stuart...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69196
Blamelist: will...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69200
Blamelist: dhol...@chromium.org,nirn...@chromium.org,r...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69203
Blamelist: nirn...@chromium.org,rsi...@chromium.org,s...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69204
Blamelist: bau...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69205
Blamelist: will...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69206
Blamelist: cs...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69208
Blamelist: ev...@chromium.org
Nico Weber
> On Tue, Dec 14, 2010 at 12:12 PM, Hans Wennborg <ha...@chromium.org> wrote:
>> On Tue, Dec 14, 2010 at 12:07 PM, Hans Wennborg <ha...@chromium.org> wrote:
>>> On Tue, Dec 14, 2010 at 8:09 AM, Nico Weber <tha...@google.com> wrote:
>>>> satish: FYI
>>>>
>>>> Not sure if this is your fault or clang's, will take a look tomorrow.
>>>
>>> Here's a reduction...
>>>
>>> #include <cstdio>
>>>
>>> // From base/singleton.h
>>> template <typename Type>
>>> class Singleton {
>>> private:
>>> friend Type* Type::GetInstance();
>>>
>>> static Type* get() {
>>> return 0; // More magic here in reality...
>>> }
>>> };
>>>
>>> // From chrome/browser/about_flags.cc
>>> namespace {
>>>
>>> class FlagState {
>>> public:
>>> static FlagState* GetInstance() {
>>> return Singleton<FlagState>::get();
>>> }
>>> };
>>>
>>> } // namespace
>>>
>>> void f() {
>>> FlagState* f = FlagState::GetInstance();
>>> std::printf("%p\n", f);
>>> }
>>>
>>> // A main() so we can try to link it.
>>> int main() {
>>> f();
>>> }
>>>
>>>
>>> clang++ /tmp/a.cc
>>> /usr/bin/ld: /tmp/cc-1QAUEc.o: in function f():/tmp/a.cc(.text+0x9):
>>> error: undefined reference to '(anonymous
>>> namespace)::FlagState::GetInstance()'
>>> clang: error: linker command failed with exit code 1 (use -v to see invocation)
>>>
>>>
>>
>> Satish asked whether defining FlagState::GetInstance() out-of-line
>> helps, and indeed it does; the error goes away.
>>
>> This definitely feels like a Clang bug. I'll try to reduce it a bit
>> more and file a bug.
>
> Filed http://llvm.org/pr8789
Thanks for tracking this down!
I have a fix out for review. If the comments are minor, I will roll
clang on the bots after landing it. If the fix is totally wrong, I
will submit some kind of workaround to get the bots green again until
I come up with a correct fix. In any caes, I'd like to get the bots
green again some time tomorrow.
Nico
>
>>
>>>
>>>>
>>>> On Mon, Dec 13, 2010 at 11:56 PM, <cl...@chromium.org> wrote:
>>>>> The Buildbot has detected a failed build of Chromium Linux Debug Clang on Chromium FYI.
>>>>> Full details are available at:
>>>>> http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Linux%20Debug%20Clang/builds/3574
>>>>>
>>>>> Buildbot URL: http://build.chromium.org/p/chromium.fyi/
>>>>>
>>>>> Buildslave for this Build: vm79-m1
>>>>>
>>>>> Build Reason:
>>>>> Build Source Stamp: [branch src] 69107
>>>>> Blamelist: sat...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69210
Blamelist: ma...@chromium.org,tess...@google.com
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69211
Blamelist: nd...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69212
Blamelist: oj...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69213
Blamelist: ana...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69214
Blamelist: tfa...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69215
Blamelist: jia...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69216
Blamelist: kka...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69217
Blamelist: will...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69218
Blamelist: ana...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69219
Blamelist: rsi...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69220
Blamelist: will...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69221
Blamelist: bau...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69222
Blamelist: pete...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69223
Blamelist: j...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69228
Blamelist: tfa...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69229
Blamelist: will...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69231
Blamelist: ishe...@chromium.org
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69232
cl...@chromium.org
Full details are available at:
Buildbot URL: http://build.chromium.org/p/chromium.fyi/
Buildslave for this Build: vm79-m1
Build Reason:
Build Source Stamp: [branch src] 69233
Blamelist: will...@chromium.org